Skip to content

Commit b38e53c

Browse files
committed
usb: usblp: fix uninitialized heap leak via LPGETSTATUS ioctl
Just like in a previous problem in this driver, usblp_ctrl_msg() will collapse the usb_control_msg() return value to 0/-errno, discarding the actual number of bytes transferred. Ideally that short command should be detected and error out, but many printers are known to send "incorrect" responses back so we can't just do that. statusbuf is kmalloc(8) at probe time and never filled before the first LPGETSTATUS ioctl. usblp_read_status() requests 1 byte. If a malicious printer responds with zero bytes, *statusbuf is one byte of stale kmalloc heap, sign-extended into the local int status, which the LPGETSTATUS path then copy_to_user()s directly to the ioctl caller. Fix this all by just zapping out the memory buffer when allocated at probe time. If a later call does a short read, the data will be identical to what the device sent it the last time, so there is no "leak" of information happening. Cc: Pete Zaitcev <zaitcev@redhat.com> Assisted-by: gkh_clanker_t1000 Cc: stable <stable@kernel.org> Link: https://patch.msgid.link/2026042011-shredder-savage-48c6@gregkh Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7a400c6 commit b38e53c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/usb/class/usblp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,7 @@ static int usblp_probe(struct usb_interface *intf,
11781178
}
11791179

11801180
/* Allocate buffer for printer status */
1181-
usblp->statusbuf = kmalloc(STATUS_BUF_SIZE, GFP_KERNEL);
1181+
usblp->statusbuf = kzalloc(STATUS_BUF_SIZE, GFP_KERNEL);
11821182
if (!usblp->statusbuf) {
11831183
retval = -ENOMEM;
11841184
goto abort;

0 commit comments

Comments
 (0)