Skip to content

Commit d2ec0e8

Browse files
rchatreshuahkh
authored andcommitted
selftests/resctrl: Raise threshold at which MBM and PMU values are compared
Commit 501cfdb ("selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth") introduced a threshold under which memory bandwidth values from MBM and performance counters are not compared. This is needed because MBM and the PMUs do not have an identical view of memory bandwidth since PMUs can count all memory traffic while MBM does not count "overhead" (for example RAS) traffic that cannot be attributed to an RMID. As a ratio this difference in view of memory bandwidth is pronounced at low memory bandwidths. The 750MiB threshold was chosen arbitrarily after comparisons on different platforms. Exposed to more platforms after introduction this threshold has proven to be inadequate. Having accurate comparison between performance counters and MBM requires careful management of system load as well as control of features that introduce extra memory traffic, for example, patrol scrub. This is not appropriate for the resctrl selftests that are intended to run on a variety of systems with various configurations. Increase the memory bandwidth threshold under which no comparison is made between performance counters and MBM. Add additional leniency by increasing the percentage of difference that will be tolerated between these counts. There is no impact to the validity of the resctrl selftests results as a measure of resctrl subsystem health. Link: https://lore.kernel.org/r/b374c33ddd324130d6255cbb91c3dd500e8277e7.1775266384.git.reinette.chatre@intel.com Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Tested-by: Chen Yu <yu.c.chen@intel.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
1 parent 752b693 commit d2ec0e8

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

tools/testing/selftests/resctrl/mba_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
#define RESULT_FILE_NAME "result_mba"
1414
#define NUM_OF_RUNS 5
15-
#define MAX_DIFF_PERCENT 8
15+
#define MAX_DIFF_PERCENT 15
1616
#define ALLOCATION_MAX 100
1717
#define ALLOCATION_MIN 10
1818
#define ALLOCATION_STEP 10

tools/testing/selftests/resctrl/mbm_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include "resctrl.h"
1212

1313
#define RESULT_FILE_NAME "result_mbm"
14-
#define MAX_DIFF_PERCENT 8
14+
#define MAX_DIFF_PERCENT 15
1515
#define NUM_OF_RUNS 5
1616

1717
static int

tools/testing/selftests/resctrl/resctrl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
* and MBM respectively, for instance generating "overhead" traffic which
5656
* is not counted against any specific RMID.
5757
*/
58-
#define THROTTLE_THRESHOLD 750
58+
#define THROTTLE_THRESHOLD 2500
5959

6060
/*
6161
* fill_buf_param: "fill_buf" benchmark parameters

0 commit comments

Comments
 (0)