Skip to content

Commit 6a17582

Browse files
committed
chore: bump windows crate min to 0.61 due to lack-of-implement feature
1 parent 5722483 commit 6a17582

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/cpal.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,8 +320,6 @@ jobs:
320320
fail-fast: false
321321
matrix:
322322
include:
323-
- windows-version: "0.59.0"
324-
- windows-version: "0.60.0"
325323
- windows-version: "0.61.3"
326324
# Skip 0.62.x since we already test current version in test-native
327325
name: test-windows-v${{ matrix.windows-version }}

Cargo.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,12 @@ clap = { version = "4.5", features = ["derive"] }
3131
# versions when bumping to a new release, and only increase the minimum when absolutely necessary.
3232
# When updating this, also update the "windows-version" matrix in the CI workflow.
3333
[target.'cfg(target_os = "windows")'.dependencies]
34-
windows = { version = ">=0.58, <=0.62", features = [
34+
# The `implement` feature was removed in windows-0.61, which means that we can't
35+
# use older versions of the `windows` crate without explicitly activating `implement`
36+
# for them, which will cause problems for >=0.61.
37+
#
38+
# See <https://github.com/microsoft/windows-rs/pull/3333>.
39+
windows = { version = ">=0.61, <=0.62", features = [
3540
"Win32_Media_Audio",
3641
"Win32_Foundation",
3742
"Win32_Devices_Properties",

0 commit comments

Comments
 (0)