refactor(asio): align atomic store/load API with JACK#1217
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the ASIO backend’s StreamState atomic load/store helpers to match the API shape used by the JACK backend, making the ordering explicit at call sites and keeping the two implementations consistent.
Changes:
- Update
StreamState::loadto accept anOrderingparameter and use it for atomic loads. - Update
StreamState::storeto be a method onselfand accept anOrderingparameter for atomic stores. - Adjust ASIO stream control and callbacks to pass appropriate
Orderingvalues (Releasefor stores,Acquirefor loads).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.