Skip to content

ci: check with all features#1240

Merged
roderickvd merged 4 commits into
masterfrom
ci/check-all-features
Jun 7, 2026
Merged

ci: check with all features#1240
roderickvd merged 4 commits into
masterfrom
ci/check-all-features

Conversation

@roderickvd
Copy link
Copy Markdown
Member

Ensure the following all work out of the box - assuming availability of system libraries:

  1. Compiling with default features
  2. Compiling with no default features (equal to item 1; so removed to save the CI effort)
  3. Compiling with all features

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the platform CI workflow to validate that cpal compiles and tests successfully with default features and with all features enabled, while removing redundant --no-default-features runs (since default = []).

Changes:

  • Remove --no-default-features test/check steps across multiple jobs to reduce CI work.
  • Ensure “all features” builds are covered across platforms, including adding/expanding checks for the WebAssembly jobs.
  • Add missing “default features” example checks in the wasm jobs for baseline parity.
Comments suppressed due to low confidence (1)

.github/workflows/platforms.yml:152

  • In the linux-armv7 job, the step labeled “Check examples (all features)” is actually running cross ... test and doesn’t pass --examples, so it won’t check example compilation at all. Also, both steps are labeled “all features” but only enable jack,pulseaudio, which is misleading in CI output.
      - name: Run tests (all features)
        run: cross +${{ steps.msrv.outputs.all-features }} test --features=jack,pulseaudio --workspace --verbose --target ${{ env.TARGET }}

      - name: Check examples (all features)
        run: cross +${{ steps.msrv.outputs.all-features }} test --features=jack,pulseaudio --workspace --verbose --target ${{ env.TARGET }}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roderickvd roderickvd merged commit 50d9646 into master Jun 7, 2026
32 checks passed
@roderickvd roderickvd deleted the ci/check-all-features branch June 7, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants