ci: check with all features#1240
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the platform CI workflow to validate that cpal compiles and tests successfully with default features and with all features enabled, while removing redundant --no-default-features runs (since default = []).
Changes:
- Remove
--no-default-featurestest/check steps across multiple jobs to reduce CI work. - Ensure “all features” builds are covered across platforms, including adding/expanding checks for the WebAssembly jobs.
- Add missing “default features” example checks in the wasm jobs for baseline parity.
Comments suppressed due to low confidence (1)
.github/workflows/platforms.yml:152
- In the
linux-armv7job, the step labeled “Check examples (all features)” is actually runningcross ... testand doesn’t pass--examples, so it won’t check example compilation at all. Also, both steps are labeled “all features” but only enablejack,pulseaudio, which is misleading in CI output.
- name: Run tests (all features)
run: cross +${{ steps.msrv.outputs.all-features }} test --features=jack,pulseaudio --workspace --verbose --target ${{ env.TARGET }}
- name: Check examples (all features)
run: cross +${{ steps.msrv.outputs.all-features }} test --features=jack,pulseaudio --workspace --verbose --target ${{ env.TARGET }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the following all work out of the box - assuming availability of system libraries: