Upgrade dependencies#32
Open
Stigjb wants to merge 3 commits into
Open
Conversation
num and rand dependencies were old
The Rand trait is deprecated, impl Distribution for Standard instead
est31
requested changes
May 13, 2020
est31
left a comment
est31
left a comment
Member
There was a problem hiding this comment.
The >= and < dependency style is a forward compatibility hazard. Could you instead just increase the number to the latest dependency versions? Also, is really the entire num crate needed, or can one of its dependencies be used as well?
Contributor
Author
|
It turns out that everything from I understeed that you wanted the dependencies to be the latest versions, which will lose compatibility with older versions of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependencies are quite old, and I couldn't compile the crate in my project which uses a more recent version of
rand.I've made the
numdependency a greater range of versions, as long as they are below v1.I've raised the minimum version of
randto 0.5, which is when theRandtrait was deprecated, and changed the implementation ofRandforLetterto conform to the newer API.I've successfully compiled the crate with recent versions of rand on my PR branch.