Don't make controller a default feature

Author: wmedrano

.github/workflows/site.yml

@@ -28,12 +28,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Setup Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 3.0
-          bundler-cache: true
-          cache-version: 0 # Increment this number to re-download cached gems.
       - name: Setup Pages
         id: pages
         uses: actions/configure-pages@v5

Cargo.toml

@@ -24,6 +24,6 @@ crossbeam-channel = "0.5"
 ctor = "0.2"
 
 [features]
-default = ["dynamic_loading", "log", "controller"]
+default = ["dynamic_loading", "log"]
 dynamic_loading = ["jack-sys/dynamic_loading"]
 controller = ["rtrb"]

docs/src/contrib/controller.md

@@ -1,5 +1,8 @@
 # Controller
 
+**Note:** This module requires the `controller` feature, which is not enabled by default.
+Add `jack = { version = "...", features = ["controller"] }` to your `Cargo.toml`.
+
 The controller module provides utilities for building controllable JACK processors
 with lock-free communication. This is useful when you need to send commands to or
 receive notifications from your audio processor without blocking the real-time thread.

docs/src/features.md

@@ -30,3 +30,11 @@ Default: Yes
 Load `libjack` at runtime as opposed to the standard dynamic linking. This is
 preferred as it allows `pw-jack` to intercept the loading at runtime to provide
 the Pipewire JACK server implementation.
+
+## `controller`
+
+Default: No
+
+Enables the `jack::contrib::controller` module which provides utilities for
+building controllable JACK processors with lock-free communication. See the
+[Controller documentation](contrib/controller.md) for usage details.

src/contrib/controller.rs

@@ -145,12 +145,7 @@ impl<T: ControlledProcessorTrait> ProcessHandler for ControlledProcessorInstance
         self.inner.buffer_size(client, size, &mut self.channels)
     }
 
-    fn sync(
-        &mut self,
-        client: &Client,
-        state: TransportState,
-        pos: &TransportPosition,
-    ) -> bool {
+    fn sync(&mut self, client: &Client, state: TransportState, pos: &TransportPosition) -> bool {
         self.inner.sync(client, state, pos, &mut self.channels)
     }
 }