Skip to content

ml-kem: bump pkcs8 to v0.11.0-rc.12 #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Apr 27, 2026
+8 −8
Merged

ml-kem: bump pkcs8 to v0.11.0-rc.12 #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ml-kem/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ sha3 = { version = "0.11", default-features = false }

# optional dependencies
const-oid = { version = "0.10.1", optional = true, default-features = false, features = ["db"] }
pkcs8 = { version = "0.11.0-rc.11", optional = true, default-features = false }
pkcs8 = { version = "0.11.0-rc.12", optional = true, default-features = false }
zeroize = { version = "1.8.1", optional = true, default-features = false }

[dev-dependencies]
Expand Down
6 changes: 3 additions & 3 deletions ml-kem/src/pkcs8.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ where
/// Serialize the given `DecapsulationKey` into DER format.
/// Returns a `SecretDocument` which wraps the DER document in case of success.
fn to_pkcs8_der(&self) -> ::pkcs8::Result<pkcs8::SecretDocument> {
let seed = self.to_seed().ok_or(pkcs8::Error::KeyMalformed)?;
let seed = self.to_seed().ok_or(pkcs8::KeyError::Invalid)?;

let seed_der = SeedString {
tag_mode: TagMode::Implicit,
Expand Down Expand Up @@ -189,12 +189,12 @@ where

let mut reader = SliceReader::new(private_key_info_ref.private_key.as_bytes())?;
let seed_string = SeedString::decode_implicit(&mut reader, SEED_TAG_NUMBER)?
.ok_or(pkcs8::Error::KeyMalformed)?;
.ok_or(pkcs8::KeyError::Invalid)?;
let seed = seed_string
.value
.as_bytes()
.try_into()
.map_err(|_| pkcs8::Error::KeyMalformed)?;
.map_err(|_| pkcs8::KeyError::Invalid)?; // TODO(tarcieri): more specific error
reader.finish()?;

Ok(Self::from_seed(seed))
Expand Down