Use Traits#378
Merged
Merged
Conversation
Member
Surprised to hear that. Opened #379.
What problems are you having? |
Contributor
Author
|
Just rebuilt my tool and it looks like a basic version conflict. |
Member
|
@tcyrus I actually noticed a bug in the recent release of the elliptic curve crates and fixed it and cut another release, so hopefully that was the solution |
tarcieri
approved these changes
Jun 16, 2025
Contributor
Author
|
Forgot to push this out, but it might be a good idea for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FromandTryFromtraits so thatDsaPrivateKey,EcdsaPrivateKey, andOpaquePrivateKeyBytescan be created from bytes without needing theencoding::Decodetrait (ssh-keydoesn't exportssh-encoding, so I had some issues with this).PrivateKeyandPublicKeyusingstd::io::{Write, Read}traits (std only). This allows you to read / write files without needing to provide a pathAsRef<Path>instead of&PathforPrivateKeyandPublicKeyI'd appreciate it if this could be back-ported to
0.6.x. Thev0.7.0-rc.0release isn't working for me.