ssh-key: use std::env::home_dir instead of home crate#415
Merged
Conversation
Prior to Rust 1.86, `std::env::home_dir` was deprecated in favor of the `home` crate. However, Rust 1.86 fixed the behavior of the function on Windows to use the `USERPROFILE` environment variable with a fallback to `GetUserProfileDirectory`, meaning we no longer need to use a crate for this purpose. Also, `home` now has an MSRV of 1.88, which would complicate our plans to launch with an MSRV of 1.85.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to Rust 1.86,
std::env::home_dirwas deprecated in favor of thehomecrate. However, Rust 1.86 fixed the behavior of the function on Windows to use theUSERPROFILEenvironment variable with a fallback toGetUserProfileDirectory, meaning we no longer need to use a crate for this purpose.Also,
homenow has an MSRV of 1.88, which would complicate our plans to launch with an MSRV of 1.85 (see #413).