Remove bits features

Upstream support was removed in RustCrypto/traits#2417.

See also: zkcrypto/ff#157

Author: tarcieri

.github/workflows/ed448-goldilocks.yml

@@ -90,8 +90,7 @@ jobs:
       - uses: RustCrypto/actions/cargo-hack-install@master
       - run: ${{ matrix.deps }}
       - run: cargo test --target ${{ matrix.target }} --no-default-features
-      - run: cargo hack test --feature-powerset --target ${{ matrix.target }} --exclude-features bits,std
-      - run: cargo test --target ${{ matrix.target }} --features bits
+      - run: cargo hack test --feature-powerset --target ${{ matrix.target }} --exclude-features std
       - run: cargo test --target ${{ matrix.target }} --features std
       - run: cargo test --target ${{ matrix.target }} --all-features
       - run: cargo test --release --target ${{ matrix.target }} --all-features

.github/workflows/k256.yml

@@ -41,7 +41,6 @@ jobs:
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features alloc
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features arithmetic
-      - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features bits
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features critical-section
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features ecdh
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features ecdsa-core
@@ -55,7 +54,7 @@ jobs:
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features sha256
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features ecdsa
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features ecdsa,sha256
-      - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features bits,critical-section,ecdh,ecdsa,group-digest,pem,pkcs8,schnorr,serde,sha256
+      - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features critical-section,ecdh,ecdsa,group-digest,pem,pkcs8,schnorr,serde,sha256
 
   benches:
     runs-on: ubuntu-latest

.github/workflows/p256.yml

@@ -41,7 +41,6 @@ jobs:
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features alloc
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features arithmetic
-      - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features bits
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features ecdh
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features ecdsa-core
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features ecdsa
@@ -52,7 +51,7 @@ jobs:
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features pkcs8
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features serde
       - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features sha256
-      - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features alloc,bits,ecdh,ecdsa,group-digest,oprf,pem,pkcs8,serde,sha256
+      - run: cargo build --target thumbv7em-none-eabi --release --no-default-features --features alloc,ecdh,ecdsa,group-digest,oprf,pem,pkcs8,serde,sha256
 
   benches:
     runs-on: ubuntu-latest

Cargo.lock

@@ -49,7 +49,6 @@ alloc = ["elliptic-curve/alloc", "primeorder?/alloc"]
 std = ["alloc", "elliptic-curve/std", "getrandom"]
 
 arithmetic = ["dep:primefield", "dep:primeorder", "elliptic-curve/arithmetic"]
-bits = ["arithmetic", "elliptic-curve/bits"]
 ecdsa = ["arithmetic", "dep:signature", "dep:belt-hash", "dep:bign-genk", "dep:belt-block", "belt-block/cipher", "belt-hash/oid"]
 getrandom = ["elliptic-curve/getrandom"]
 pem = ["pkcs8/pem", "sec1/pem"]

bignp256/Cargo.toml

@@ -143,7 +143,3 @@ pub type NonZeroScalar = elliptic_curve::NonZeroScalar<BignP256>;
 /// Generic scalar type with primitive functionality.#
 #[cfg(feature = "arithmetic")]
 pub type ScalarValue = elliptic_curve::ScalarValue<BignP256>;
-
-/// Bit representation of a BIGN P-256 scalar field element.
-#[cfg(feature = "bits")]
-pub type ScalarBits = elliptic_curve::scalar::ScalarBits<BignP256>;

bignp256/src/lib.rs

@@ -32,7 +32,6 @@ alloc = ["ecdsa?/alloc", "elliptic-curve/alloc", "primeorder?/alloc"]
 std = ["alloc", "ecdsa?/std", "elliptic-curve/std", "getrandom"]
 
 arithmetic = ["dep:primefield", "dep:primeorder"]
-bits = ["arithmetic", "elliptic-curve/bits"]
 getrandom = ["ecdsa?/getrandom", "elliptic-curve/getrandom"]
 pem = ["elliptic-curve/pem", "pkcs8"]
 pkcs8 = ["ecdsa/pkcs8", "elliptic-curve/pkcs8"]

bp256/Cargo.toml

@@ -32,7 +32,6 @@ alloc = ["ecdsa?/alloc", "elliptic-curve/alloc", "primeorder?/alloc"]
 std = ["alloc", "ecdsa?/std", "elliptic-curve/std", "getrandom"]
 
 arithmetic = ["dep:primefield", "dep:primeorder"]
-bits = ["arithmetic", "elliptic-curve/bits"]
 getrandom = ["ecdsa?/getrandom", "elliptic-curve/getrandom"]
 pem = ["elliptic-curve/pem", "pkcs8"]
 pkcs8 = ["ecdsa/pkcs8", "elliptic-curve/pkcs8"]

bp384/Cargo.toml

@@ -42,7 +42,6 @@ default = ["std", "signing", "pkcs8"]
 alloc = ["ed448?/alloc", "elliptic-curve/alloc", "serdect?/alloc", "signature?/alloc"]
 std = ["alloc", "getrandom"]
 
-bits = ["elliptic-curve/bits"]
 getrandom = ["elliptic-curve/getrandom"]
 pkcs8 = ["ed448/pkcs8", "elliptic-curve/pkcs8"]
 signing = ["dep:ed448", "dep:signature"]

ed448-goldilocks/Cargo.toml

@@ -54,13 +54,6 @@ pub type DecafScalarBytes = ScalarBytes<Decaf448>;
 /// The number of bytes needed to represent the safely create a scalar from a random bytes
 pub type WideDecafScalarBytes = WideScalarBytes<Decaf448>;
 
-#[cfg(feature = "bits")]
-impl From<&DecafScalar> for elliptic_curve::scalar::ScalarBits<Decaf448> {
-    fn from(scalar: &DecafScalar) -> Self {
-        scalar.scalar.to_words().into()
-    }
-}
-
 impl Reduce<Array<u8, U64>> for DecafScalar {
     fn reduce(value: &Array<u8, U64>) -> Self {
         const SEMI_WIDE_MODULUS: NonZero<U512> = NonZero::<U512>::new_unwrap(U512::from_be_hex(