Skip to content

Commit f00bbc0

Browse files
tarcieritarcieri
authored
Rename cfg(*_backend="bignum") to bigint (#1806)
I'm not sure why I chose `bignum` originally, but `bigint` matches `crypto-bigint` which is what it's supposed to imply.
1 parent 27ebd4b commit f00bbc0

26 files changed

Lines changed: 111 additions & 111 deletions

File tree

‎.github/workflows/bp256.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,6 @@ jobs:
7878
- run: cargo test
7979
- run: cargo test --all-features
8080
- env:
81-
RUSTFLAGS: '--cfg bp256_backend="bignum"'
82-
RUSTDOCFLAGS: '--cfg bp256_backend="bignum"'
81+
RUSTFLAGS: '--cfg bp256_backend="bigint"'
82+
RUSTDOCFLAGS: '--cfg bp256_backend="bigint"'
8383
run: cargo test --release --all-features

‎.github/workflows/bp384.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,6 @@ jobs:
7878
- run: cargo test
7979
- run: cargo test --all-features
8080
- env:
81-
RUSTFLAGS: '--cfg bp384_backend="bignum"'
82-
RUSTDOCFLAGS: '--cfg bp384_backend="bignum"'
81+
RUSTFLAGS: '--cfg bp384_backend="bigint"'
82+
RUSTDOCFLAGS: '--cfg bp384_backend="bigint"'
8383
run: cargo test --release --all-features

‎.github/workflows/p384.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ jobs:
100100
- run: cargo test --release --target ${{ matrix.target }}
101101
- run: cargo test --release --target ${{ matrix.target }} --all-features
102102
- env:
103-
RUSTFLAGS: '--cfg p384_backend="bignum"'
104-
RUSTDOCFLAGS: '--cfg p384_backend="bignum"'
103+
RUSTFLAGS: '--cfg p384_backend="bigint"'
104+
RUSTDOCFLAGS: '--cfg p384_backend="bigint"'
105105
run: cargo test --release --target ${{ matrix.target }} --all-features
106106

107107
cross:

‎.github/workflows/sm2.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,6 @@ jobs:
9191
- run: cargo test --release --target ${{ matrix.target }}
9292
- run: cargo test --release --target ${{ matrix.target }} --all-features
9393
- env:
94-
RUSTFLAGS: '--cfg sm2_backend="bignum"'
95-
RUSTDOCFLAGS: '--cfg sm2_backend="bignum"'
94+
RUSTFLAGS: '--cfg sm2_backend="bigint"'
95+
RUSTDOCFLAGS: '--cfg sm2_backend="bigint"'
9696
run: cargo test --release --target ${{ matrix.target }} --all-features

‎bp256/Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ sha256 = ["ecdsa/digest", "ecdsa/hazmat", "sha2"]
4141
[lints.rust.unexpected_cfgs]
4242
level = "warn"
4343
check-cfg = [
44-
'cfg(bp256_backend, values("bignum", "fiat"))', # default: "fiat"
44+
'cfg(bp256_backend, values("bigint", "fiat"))', # default: "fiat"
4545
'cfg(cpubits, values("16", "32", "64"))'
4646
]
4747

‎bp256/src/arithmetic/field.rs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ use elliptic_curve::{
2020
// TODO(tarcieri): remove this when we can use `const _` to silence warnings
2121
cpubits! {
2222
32 => {
23-
#[cfg(not(bp256_backend = "bignum"))]
23+
#[cfg(not(bp256_backend = "bigint"))]
2424
#[allow(
2525
dead_code,
2626
clippy::identity_op,
@@ -32,7 +32,7 @@ cpubits! {
3232
mod field_impl;
3333
}
3434
64 => {
35-
#[cfg(not(bp256_backend = "bignum"))]
35+
#[cfg(not(bp256_backend = "bigint"))]
3636
#[allow(
3737
dead_code,
3838
clippy::identity_op,
@@ -45,7 +45,7 @@ cpubits! {
4545
}
4646
}
4747

48-
#[cfg(not(bp256_backend = "bignum"))]
48+
#[cfg(not(bp256_backend = "bigint"))]
4949
use self::field_impl::*;
5050

5151
/// Constant representing the modulus serialized as hex.
@@ -67,14 +67,14 @@ primefield::monty_field_element! {
6767
doc: "Element in the brainpoolP256 finite field modulo p"
6868
}
6969

70-
#[cfg(bp256_backend = "bignum")]
70+
#[cfg(bp256_backend = "bigint")]
7171
primefield::monty_field_arithmetic! {
7272
name: FieldElement,
7373
params: FieldParams,
7474
uint: U256
7575
}
7676

77-
#[cfg(not(bp256_backend = "bignum"))]
77+
#[cfg(not(bp256_backend = "bigint"))]
7878
primefield::fiat_monty_field_arithmetic! {
7979
name: FieldElement,
8080
params: FieldParams,
@@ -97,15 +97,15 @@ primefield::fiat_monty_field_arithmetic! {
9797
#[cfg(test)]
9898
mod tests {
9999
use super::{FieldElement, U256};
100-
#[cfg(not(bp256_backend = "bignum"))]
100+
#[cfg(not(bp256_backend = "bigint"))]
101101
use super::{
102102
FieldParams, fiat_bp256_montgomery_domain_field_element, fiat_bp256_msat,
103103
fiat_bp256_non_montgomery_domain_field_element, fiat_bp256_to_montgomery,
104104
};
105105

106106
primefield::test_primefield!(FieldElement, U256);
107107

108-
#[cfg(not(bp256_backend = "bignum"))]
108+
#[cfg(not(bp256_backend = "bigint"))]
109109
primefield::test_fiat_monty_field_arithmetic!(
110110
name: FieldElement,
111111
params: FieldParams,

‎bp256/src/arithmetic/scalar.rs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ use elliptic_curve::{
2121
// TODO(tarcieri): remove this when we can use `const _` to silence warnings
2222
cpubits! {
2323
32 => {
24-
#[cfg(not(bp256_backend = "bignum"))]
24+
#[cfg(not(bp256_backend = "bigint"))]
2525
#[path = "scalar/bp256_scalar_32.rs"]
2626
#[allow(
2727
dead_code,
@@ -33,7 +33,7 @@ cpubits! {
3333
mod scalar_impl;
3434
}
3535
64 => {
36-
#[cfg(not(bp256_backend = "bignum"))]
36+
#[cfg(not(bp256_backend = "bigint"))]
3737
#[path = "scalar/bp256_scalar_64.rs"]
3838
#[allow(
3939
dead_code,
@@ -46,7 +46,7 @@ cpubits! {
4646
}
4747
}
4848

49-
#[cfg(not(bp256_backend = "bignum"))]
49+
#[cfg(not(bp256_backend = "bigint"))]
5050
use self::scalar_impl::*;
5151

5252
#[cfg(doc)]
@@ -68,14 +68,14 @@ primefield::monty_field_element! {
6868
doc: "Element in the brainpoolP256 scalar field modulo n"
6969
}
7070

71-
#[cfg(bp256_backend = "bignum")]
71+
#[cfg(bp256_backend = "bigint")]
7272
primefield::monty_field_arithmetic! {
7373
name: Scalar,
7474
params: ScalarParams,
7575
uint: U256
7676
}
7777

78-
#[cfg(not(bp256_backend = "bignum"))]
78+
#[cfg(not(bp256_backend = "bigint"))]
7979
primefield::fiat_monty_field_arithmetic! {
8080
name: Scalar,
8181
params: ScalarParams,
@@ -128,15 +128,15 @@ impl IsHigh for Scalar {
128128
#[cfg(test)]
129129
mod tests {
130130
use super::{Scalar, U256};
131-
#[cfg(not(bp256_backend = "bignum"))]
131+
#[cfg(not(bp256_backend = "bigint"))]
132132
use super::{
133133
ScalarParams, fiat_bp256_scalar_montgomery_domain_field_element, fiat_bp256_scalar_msat,
134134
fiat_bp256_scalar_non_montgomery_domain_field_element, fiat_bp256_scalar_to_montgomery,
135135
};
136136

137137
primefield::test_primefield!(Scalar, U256);
138138

139-
#[cfg(not(bp256_backend = "bignum"))]
139+
#[cfg(not(bp256_backend = "bigint"))]
140140
primefield::test_fiat_monty_field_arithmetic!(
141141
name: Scalar,
142142
params: ScalarParams,

‎bp256/src/lib.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@
1818
//! ## Backends
1919
//!
2020
//! This crate has support for two different field arithmetic backends which can be selected using
21-
//! `cfg(bp256_backend)`, e.g. to select the `bignum` backend:
21+
//! `cfg(bp256_backend)`, e.g. to select the `bigint` backend:
2222
//!
2323
//! ```console
24-
//! $ RUSTFLAGS='--cfg bp256_backend="bignum"' cargo test
24+
//! $ RUSTFLAGS='--cfg bp256_backend="bigint"' cargo test
2525
//! ```
2626
//!
2727
//! Or it can be set through [`.cargo/config`][buildrustflags]:
2828
//!
2929
//! ```toml
3030
//! [build]
31-
//! rustflags = ['--cfg', 'bp256_backend="bignum"']
31+
//! rustflags = ['--cfg', 'bp256_backend="bigint"']
3232
//! ```
3333
//!
3434
//! The available backends are:
35-
//! - `bignum`: experimental backend provided by [crypto-bigint]. May offer better performance in
35+
//! - `bigint`: experimental backend provided by [crypto-bigint]. May offer better performance in
3636
//! some cases along with smaller code size, but might also have bugs.
3737
//! - `fiat` (default): formally verified implementation synthesized by [fiat-crypto] which should
3838
//! be correct for all inputs (though there's a possibility of bugs in the code which glues to it)

‎bp384/Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ sha384 = ["ecdsa/digest", "ecdsa/hazmat", "sha2"]
4141
[lints.rust.unexpected_cfgs]
4242
level = "warn"
4343
check-cfg = [
44-
'cfg(bp384_backend, values("bignum", "fiat"))', # default: "fiat"
44+
'cfg(bp384_backend, values("bigint", "fiat"))', # default: "fiat"
4545
'cfg(cpubits, values("16", "32", "64"))'
4646
]
4747

‎bp384/src/arithmetic/field.rs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ use elliptic_curve::{
2020
// TODO(tarcieri): remove this when we can use `const _` to silence warnings
2121
cpubits! {
2222
32 => {
23-
#[cfg(not(bp384_backend = "bignum"))]
23+
#[cfg(not(bp384_backend = "bigint"))]
2424
#[path = "field/bp384_32.rs"]
2525
#[allow(
2626
dead_code,
@@ -32,7 +32,7 @@ cpubits! {
3232
mod field_impl;
3333
}
3434
64 => {
35-
#[cfg(not(bp384_backend = "bignum"))]
35+
#[cfg(not(bp384_backend = "bigint"))]
3636
#[path = "field/bp384_64.rs"]
3737
#[allow(
3838
dead_code,
@@ -45,7 +45,7 @@ cpubits! {
4545
}
4646
}
4747

48-
#[cfg(not(bp384_backend = "bignum"))]
48+
#[cfg(not(bp384_backend = "bigint"))]
4949
use self::field_impl::*;
5050

5151
/// Constant representing the modulus serialized as hex.
@@ -67,14 +67,14 @@ primefield::monty_field_element! {
6767
doc: "Element in the brainpoolP384 finite field modulo p"
6868
}
6969

70-
#[cfg(bp384_backend = "bignum")]
70+
#[cfg(bp384_backend = "bigint")]
7171
primefield::monty_field_arithmetic! {
7272
name: FieldElement,
7373
params: FieldParams,
7474
uint: U384
7575
}
7676

77-
#[cfg(not(bp384_backend = "bignum"))]
77+
#[cfg(not(bp384_backend = "bigint"))]
7878
primefield::fiat_monty_field_arithmetic! {
7979
name: FieldElement,
8080
params: FieldParams,
@@ -97,15 +97,15 @@ primefield::fiat_monty_field_arithmetic! {
9797
#[cfg(test)]
9898
mod tests {
9999
use super::{FieldElement, U384};
100-
#[cfg(not(bp384_backend = "bignum"))]
100+
#[cfg(not(bp384_backend = "bigint"))]
101101
use super::{
102102
FieldParams, fiat_bp384_montgomery_domain_field_element, fiat_bp384_msat,
103103
fiat_bp384_non_montgomery_domain_field_element, fiat_bp384_to_montgomery,
104104
};
105105

106106
primefield::test_primefield!(FieldElement, U384);
107107

108-
#[cfg(not(bp384_backend = "bignum"))]
108+
#[cfg(not(bp384_backend = "bigint"))]
109109
primefield::test_fiat_monty_field_arithmetic!(
110110
name: FieldElement,
111111
params: FieldParams,

0 commit comments

Comments
 (0)