ed448-goldilocks: enforce RFC 8032 context length in Ed448 verification#1387
Open
radik878 wants to merge 4 commits intoRustCrypto:masterfrom
Open
ed448-goldilocks: enforce RFC 8032 context length in Ed448 verification#1387radik878 wants to merge 4 commits intoRustCrypto:masterfrom
radik878 wants to merge 4 commits intoRustCrypto:masterfrom
Conversation
tarcieri
reviewed
Sep 13, 2025
Co-authored-by: Tony Arcieri <bascule@gmail.com>
tarcieri
reviewed
Sep 14, 2025
tarcieri
changed the title
Co-authored-by: Tony Arcieri <bascule@gmail.com>
Contributor
Author
|
Yes ser, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a guard in VerifyingKey::verify_inner to error when ctx.len() > 255 instead of truncating to u8. Aligns verification behavior with signing (ExpandedSecretKey::sign_inner) and prevents silent context truncation.