p521: fix size of CompressedPoint#1652
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Apr 8, 2026
Merged
Conversation
tarcieri
approved these changes
Apr 8, 2026
tarcieri
changed the title
CompressedPoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: The P-521 CompressedPoint alias used U66 (field size) instead of the full SEC1 compressed length, omitting the one-byte prefix. This was inconsistent with SEC1, the generic sec1::CompressedPoint implementation, and the other curves in this repo.
Summary: Import U67 and update the P-521 CompressedPoint alias to Array<u8, U67>, so it matches the SEC1 compressed point size and the behavior of the generic sec1 encoding utilities.