Skip to content

p521: fix size of CompressedPoint #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Apr 8, 2026
+18 −2
Merged

p521: fix size of CompressedPoint #1652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions p521/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ use elliptic_curve::{
FieldBytesEncoding,
array::Array,
bigint::{Odd, cpubits},
consts::U66,
consts::{U66, U67},
};

cpubits! {
Expand Down Expand Up @@ -106,7 +106,7 @@ impl pkcs8::AssociatedOid for NistP521 {
}

/// Compressed SEC1-encoded NIST P-521 curve point.
pub type CompressedPoint = Array<u8, U66>;
pub type CompressedPoint = Array<u8, U67>;

/// NIST P-521 SEC1 encoded point.
pub type Sec1Point = elliptic_curve::sec1::Sec1Point<NistP521>;
Expand Down Expand Up @@ -135,3 +135,19 @@ impl hash2curve::OprfParameters for NistP521 {
/// See <https://www.rfc-editor.org/rfc/rfc9497.html#section-4.5-1>.
const ID: &'static [u8] = b"P521-SHA512";
}

#[cfg(test)]
mod tests {
use super::{CompressedPoint, NistP521};
use core::mem::size_of;
use elliptic_curve::sec1::CompressedPoint as Sec1Compressed;

#[test]
fn compressed_point_size_matches_sec1() {
assert_eq!(size_of::<CompressedPoint>(), 67);
assert_eq!(
size_of::<CompressedPoint>(),
size_of::<Sec1Compressed<NistP521>>(),
);
}
}