primeorder: mul_by_generator_and_mul_add_vartime method for PrimeCurveParams#1759
Merged
Merged
Conversation
Adds a trait method that can be overridden to plug in variable-time linear combinations using precomputed wNAF for the basepoint which otherwise uses `lincomb_vartime` by default. When used in `p256` in combination with RustCrypto/traits#2405 which added `BasepointTableVartime::lincomb`, this results in a 25% speedup for ECDSA verification: ECDSA/P-256 (SHA-256)/verify time: [146.21 µs 147.14 µs 148.38 µs] change: [−25.356% −24.522% −23.756%] (p = 0.00 < 0.05) Performance has improved. Also applies the optimization to `p384`, `p521`, and `sm2`.
tarcieri
force-pushed
the
primeorder/vartime-basepoint-lincomb-support
branch
from
a415ae8 to
29b2897
Compare
tarcieri
changed the title
PrimeCurveParams::mul_by_generator_and_mul_add_vartimemul_by_generator_and_mul_add_vartime method for PrimeCurveParams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a trait method that can be overridden to plug in variable-time linear combinations using precomputed wNAF for the basepoint which otherwise uses
lincomb_vartimeby default.When used in
p256in combination with RustCrypto/traits#2405 which addedBasepointTableVartime::lincomb, this results in a 25% speedup for ECDSA verification: