der: allow SetOf* duplicates#2272
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Apr 3, 2026
Merged
Conversation
tarcieri
reviewed
Apr 2, 2026
|
|
||
| /// Ensure set elements are lexicographically ordered using [`DerOrd`]. | ||
| fn check_der_ordering<T: DerOrd>(a: &T, b: &T) -> Result<(), Error> { | ||
| match a.der_cmp(b)? { |
Member
There was a problem hiding this comment.
This can probably just change to:
Suggested change
| match a.der_cmp(b)? { | |
| if a.der_cmp(b)? == Ordering::Greater { |
tarcieri
reviewed
Apr 2, 2026
| @@ -531,8 +510,7 @@ fn der_sort<T: DerOrd>(slice: &mut [T]) -> Result<(), Error> { | |||
|
|
|||
| while j > 0 { | |||
| match slice[j - 1].der_cmp(&slice[j])? { | |||
Member
There was a problem hiding this comment.
Likewise this can probably switch to an if statement
Member
|
@kraemv would you also mind adding a |
Member
|
I'll go ahead and fix up my suggestions after merging |
Contributor
Author
|
Thank you for doing the remaining fixes @tarcieri ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
this PR addresses #2271 and disables checks for duplicate elements in SetOf* structs.
The main change is removing the check_duplicate function and changing the behavior for Ordering::Equal results.
I also changed the reject_duplicates tests to allow_duplicate tests that check if duplicates are valid.
I am happy to receive feedback on the changes!