widen s_cost * p_cost to usize when sizing parallel memory#905
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the parallel feature, hash_password_into and balloon_m size the per-thread memory as s_cost * p_cost evaluated in u32 and only then cast to usize. Both come from NonZeroU32 params and can be parsed from a hash string, so a product reaching 2^32 wraps: release builds get an undersized (often zero-length) buffer and a passing MemoryTooLittle check, debug builds panic on the multiply. Casting each operand to usize first computes the real size on 64-bit targets.