avoid usize overflow when sizing scratch buffers in yescrypt_body#907
Open
dxbjavid wants to merge 1 commit into
Open
avoid usize overflow when sizing scratch buffers in yescrypt_body#907dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scratch buffers in
yescrypt_bodyare sized with32 * (r as usize) * (n as usize)and friends. r/n/p come from a parsed$y$hash, and on 32-bit targets that multiply wraps even though the u64 validation just above passes: classic-mode n=65536, r=32768 makes32*r*nreach 2^36, wrapping to 0 so V becomesvec![0; 0]andsmix1writes past it (debug builds panic on the overflow). Compute the lengths in u64, already bounded by the checks, and convert withusize::try_fromlike the existing n cast.