crypto-common: apply workspace-level lints

Adds the workspace-level config from RustCrypto/utils#1411 to this repo
and applies it to `crypto-common`.

Author: tarcieri

.clippy.toml

@@ -0,0 +1,2 @@
+allow-unwrap-in-consts = true
+allow-unwrap-in-tests = true

.github/workflows/workspace.yml

@@ -29,7 +29,7 @@ jobs:
       - uses: RustCrypto/actions/cargo-cache@master
       - uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: 1.87.0
+          toolchain: 1.93.0
           components: clippy
       - run: cargo clippy --all --all-features --tests -- -D warnings
 

Cargo.toml

@@ -14,6 +14,46 @@ members = [
     "signature",
 ]
 
+[workspace.lints.clippy]
+borrow_as_ptr = "warn"
+cast_lossless = "warn"
+cast_possible_truncation = "warn"
+cast_possible_wrap = "warn"
+cast_precision_loss = "warn"
+cast_sign_loss = "warn"
+checked_conversions = "warn"
+doc_markdown = "warn"
+from_iter_instead_of_collect = "warn"
+implicit_saturating_sub = "warn"
+manual_assert = "warn"
+map_unwrap_or = "warn"
+missing_errors_doc = "warn"
+missing_panics_doc = "warn"
+mod_module_files = "warn"
+must_use_candidate = "warn"
+needless_range_loop = "allow"
+ptr_as_ptr = "warn"
+redundant_closure_for_method_calls = "warn"
+ref_as_ptr = "warn"
+return_self_not_must_use = "warn"
+semicolon_if_nothing_returned = "warn"
+trivially_copy_pass_by_ref = "warn"
+std_instead_of_alloc = "warn"
+std_instead_of_core = "warn"
+undocumented_unsafe_blocks = "warn"
+unnecessary_safety_comment = "warn"
+unwrap_in_result = "warn"
+unwrap_used = "warn"
+
+[workspace.lints.rust]
+missing_copy_implementations = "warn"
+missing_debug_implementations = "warn"
+missing_docs = "warn"
+trivial_casts = "warn"
+trivial_numeric_casts = "warn"
+unused_lifetimes = "warn"
+unused_qualifications = "warn"
+
 [patch.crates-io]
 crypto-common = { path = "crypto-common" }
 digest = { path = "digest" }

crypto-common/Cargo.toml

@@ -24,5 +24,8 @@ getrandom = ["rand_core", "dep:getrandom"]
 rand_core = ["dep:rand_core"]
 zeroize = ["hybrid-array/zeroize"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true

crypto-common/src/generate.rs

@@ -7,9 +7,13 @@ use getrandom::{SysRng, rand_core::UnwrapErr};
 /// Secure random generation.
 pub trait Generate: Sized {
     /// Generate random key using the provided [`TryCryptoRng`].
+    ///
+    /// # Errors
+    /// Returns `R::Error` in the event the provided RNG `R` experiences an internal failure.
     fn try_generate_from_rng<R: TryCryptoRng + ?Sized>(rng: &mut R) -> Result<Self, R::Error>;
 
     /// Generate random key using the provided [`CryptoRng`].
+    #[must_use]
     fn generate_from_rng<R: CryptoRng + ?Sized>(rng: &mut R) -> Self {
         let Ok(ret) = Self::try_generate_from_rng(rng);
         ret
@@ -35,6 +39,7 @@ pub trait Generate: Sized {
     ///
     /// This shouldn't happen on most modern operating systems.
     #[cfg(feature = "getrandom")]
+    #[must_use]
     fn generate() -> Self {
         Self::generate_from_rng(&mut UnwrapErr(SysRng))
     }