elliptic-curve: deprecated MulByGenerator

This now should use `group::Group` directly.

Author: baloo

elliptic-curve/src/dev.rs

@@ -8,7 +8,7 @@ use crate::{
     array::typenum::U32,
     bigint::{Limb, U256},
     error::{Error, Result},
-    ops::{Invert, LinearCombination, MulByGenerator, Reduce, ShrAssign},
+    ops::{Invert, LinearCombination, Reduce, ShrAssign},
     point::AffineCoordinates,
     rand_core::TryRngCore,
     scalar::{FromUintUnchecked, IsHigh},
@@ -807,8 +807,6 @@ impl MulAssign<&Scalar> for ProjectivePoint {
     }
 }
 
-impl MulByGenerator for ProjectivePoint {}
-
 impl Neg for ProjectivePoint {
     type Output = ProjectivePoint;
 

elliptic-curve/src/ops.rs

@@ -2,8 +2,10 @@
 
 pub use core::ops::{Add, AddAssign, Mul, Neg, Shr, ShrAssign, Sub, SubAssign};
 
+#[deprecated(since = "0.14.0", note = "Please migrate to [`group::Group`] instead")]
+pub use group::Group as MulByGenerator;
+
 use crypto_bigint::Integer;
-use group::Group;
 use subtle::{Choice, ConditionallySelectable, CtOption};
 
 #[cfg(feature = "alloc")]
@@ -168,18 +170,6 @@ where
     }
 }
 
-/// Multiplication by the generator.
-///
-/// May use optimizations (e.g. precomputed tables) when available.
-// TODO(tarcieri): replace this with `Group::mul_by_generator``? (see zkcrypto/group#44)
-pub trait MulByGenerator: Group {
-    /// Multiply by the generator of the prime-order subgroup.
-    #[must_use]
-    fn mul_by_generator(scalar: &Self::Scalar) -> Self {
-        Self::generator() * scalar
-    }
-}
-
 /// Modular reduction.
 pub trait Reduce<Uint: Integer>: Sized {
     /// Bytes used as input to [`Reduce::reduce_bytes`].