elliptic-curve: getrandom feature#2085
Merged
Merged
Conversation
Adds support for generating `SecretKey` and `NonZeroScalar` using the system's cryptographically secure random number generator. Notably this renames the former `SecretKey::random` and `NonZeroScalar::random` methods to `SecretKey::generate` and `NonZeroScalar::generate`, which take no parameters and are infallible. This avoids the need for the user to import an `OsRng` type, or worry about the generation failing (which it won't on most notable modern OSes). If a user still wants to handle RNG errors, the `try_from_rng` method still exists, and they can pass `OsRng` if they'd like.
Member
Author
|
I think #1897 could potentially obviate the need for this, but I wanted to have a stopgap in place first before exploring that as an alternative. |
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Nov 9, 2025
Adds a `getrandom` feature which allows infallible generation of `SigningKey`s using the system's cryptographically secure RNG. Proxies through to the newly added `getrandom` feature in the `elliptic-curve` crate: RustCrypto/traits#2085
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Nov 9, 2025
Adds a `getrandom` feature which allows infallible generation of `SigningKey`s using the system's cryptographically secure RNG. Proxies through to the newly added `getrandom` feature in the `elliptic-curve` crate: RustCrypto/traits#2085
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Nov 9, 2025
Adds a `getrandom` feature which allows infallible generation of `SigningKey`s using the system's cryptographically secure RNG. Proxies through to the newly added `getrandom` feature in the `elliptic-curve` crate: RustCrypto/traits#2085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for generating
SecretKeyandNonZeroScalarusing the system's cryptographically secure random number generator. Notably this renames the formerSecretKey::randomandNonZeroScalar::randommethods toSecretKey::generateandNonZeroScalar::generate, which take no parameters and are infallible.This avoids the need for the user to import an
OsRngtype, or worry about the generation failing (which it won't on most notable modern OSes).If a user still wants to handle RNG errors, the
try_from_rngmethod still exists, and they can passOsRngif they'd like.