password-hash: restore getrandom feature#2123
Merged
Merged
Conversation
Renames `PasswordHash::hash_password` to `hash_password_with_salt`, and adds a new `getrandom`-gated method to `PasswordHash` called `hash_password`, but which only takes `&self` and `password` as arguments, automatically generating a salt of the recommended length.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 11, 2025
Companion PR to RustCrypto/traits#2123 The aforementioned traits PR renames `PasswordHash::hash_password` to `hash_password_with_salt`, so this PR updates the method name change accordingly. When the `getrandom` feature is enabled, it provides a new `PasswordHash::hash_password` which *just* accepts a password as an argument, relying on `getrandom` to internally generate a salt. This updates all the code examples to use the new API so users don't have to deal with randomly generating a salt.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 11, 2025
Companion PR to RustCrypto/traits#2123 The aforementioned traits PR renames `PasswordHash::hash_password` to `hash_password_with_salt`, so this PR updates the method name change accordingly. When the `getrandom` feature is enabled, it provides a new `PasswordHash::hash_password` which *just* accepts a password as an argument, relying on `getrandom` to internally generate a salt. This updates all the code examples to use the new API so users don't have to deal with randomly generating a salt.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 11, 2025
Companion PR to RustCrypto/traits#2123 The aforementioned traits PR renames `PasswordHash::hash_password` to `hash_password_with_salt`, so this PR updates the method name change accordingly. When the `getrandom` feature is enabled, it provides a new `PasswordHash::hash_password` which *just* accepts a password as an argument, relying on `getrandom` to internally generate a salt. This updates all the code examples to use the new API so users don't have to deal with randomly generating a salt.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 11, 2025
Companion PR to RustCrypto/traits#2123 The aforementioned traits PR renames `PasswordHash::hash_password` to `hash_password_with_salt`, so this PR updates the method name change accordingly. When the `getrandom` feature is enabled, it provides a new `PasswordHash::hash_password` which *just* accepts a password as an argument, relying on `getrandom` to internally generate a salt. This updates all the code examples to use the new API so users don't have to deal with randomly generating a salt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
PasswordHash::hash_passwordtohash_password_with_salt, and adds a newgetrandom-gated method toPasswordHashcalledhash_password, but which only takes&selfandpasswordas arguments, automatically generating a salt of the recommended length.