cpufeatures: use cfg() to detect aarch64 android instead of [target.aarch64-linux-android]#1204
Merged
Merged
Conversation
newpavlov
approved these changes
Aug 21, 2025
newpavlov
left a comment
newpavlov
left a comment
Member
There was a problem hiding this comment.
Yeah, we should mirror cfgs used in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose that, on aarch64-linux-android, cpufeatures/Cargo.toml should use
cfg(all(...))instead of full target name "aarch64-linux-android", just like the other target-specific deps on libc do.Motivation for this change is building with a custom rustc target like "aarch64-foobar-linux-android". Cargo/Rustc (and consequently the #[cfg] check in src/aarch64.rs) correctly interpret that as target_arch="aarch64", target_os="android", but the current Cargo.toml fails to include the dependency on libc.