Cargo.toml: add workspace-level clippy config

.clippy.toml

@@ -0,0 +1,2 @@
+allow-unwrap-in-consts = true
+allow-unwrap-in-tests = true

.github/workflows/blobby.yml

@@ -2,9 +2,9 @@ name: blobby
 
 on:
   pull_request:
-      paths:
-        - "blobby/**"
-        - "Cargo.*"
+    paths:
+      - "blobby/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -38,11 +38,4 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ matrix.rust }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test
-
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}

.github/workflows/block-buffer.yml

@@ -2,9 +2,9 @@ name: block-buffer
 
 on:
   pull_request:
-      paths:
-        - "block-buffer/**"
-        - "Cargo.*"
+    paths:
+      - "block-buffer/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -44,10 +44,11 @@ jobs:
           targets: ${{ matrix.target }}
       - run: cargo build --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-      working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #      working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest

.github/workflows/block-padding.yml

@@ -2,9 +2,9 @@ name: block-padding
 
 on:
   pull_request:
-      paths:
-        - "block-padding/**"
-        - "Cargo.*"
+    paths:
+      - "block-padding/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -44,10 +44,11 @@ jobs:
           targets: ${{ matrix.target }}
       - run: cargo build --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #        working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest

.github/workflows/cmov.yml

@@ -26,10 +26,11 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-      working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #      working-directory: ${{ github.workflow }}
 
   build:
     runs-on: ubuntu-latest

.github/workflows/cpufeatures.yml

@@ -25,10 +25,11 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #      working-directory: ${{ github.workflow }}
 
   # Linux tests
   linux:
@@ -56,8 +57,6 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: ${{ matrix.deps }}
       - run: cargo test --target ${{ matrix.target }}
 
@@ -76,8 +75,6 @@ jobs:
         with:
           toolchain: ${{ matrix.toolchain }}
           targets: x86_64-apple-darwin
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test
 
   # Windows tests
@@ -98,8 +95,6 @@ jobs:
         with:
           toolchain: ${{ matrix.toolchain }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test --target ${{ matrix.target }}
 
   # Cross-compiled tests
@@ -121,8 +116,6 @@ jobs:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
       - uses: RustCrypto/actions/cross-install@master
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cross test --target ${{ matrix.target }}
 
   # Build-only tests

.github/workflows/dbl.yml

@@ -45,10 +45,11 @@ jobs:
           targets: ${{ matrix.target }}
       - run: cargo build --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-      working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #      working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest

.github/workflows/hex-literal.yml

@@ -2,9 +2,9 @@ name: hex-literal
 
 on:
   pull_request:
-      paths:
-        - "hex-literal/**"
-        - "Cargo.*"
+    paths:
+      - "hex-literal/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -42,14 +42,13 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo build --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #      working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest
@@ -64,6 +63,4 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ matrix.rust }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test

.github/workflows/inout.yml

@@ -2,9 +2,9 @@ name: inout
 
 on:
   pull_request:
-      paths:
-        - "inout/**"
-        - "Cargo.*"
+    paths:
+      - "inout/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -45,10 +45,11 @@ jobs:
       - run: cargo build --target ${{ matrix.target }}
       - run: cargo build --features block-padding --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #        working-directory: ${{ github.workflow }}
 
   test:
     runs-on: ubuntu-latest

.github/workflows/opaque-debug.yml

@@ -2,9 +2,9 @@ name: opaque-debug
 
 on:
   pull_request:
-      paths:
-        - "opaque-debug/**"
-        - "Cargo.*"
+    paths:
+      - "opaque-debug/**"
+      - "Cargo.*"
   push:
     branches: master
 
@@ -42,15 +42,8 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
           targets: ${{ matrix.target }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo build --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-        working-directory: ${{ github.workflow }}
-
   test:
     runs-on: ubuntu-latest
     strategy:
@@ -64,6 +57,4 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ matrix.rust }}
-      # Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
-      - run: rm ../Cargo.toml
       - run: cargo test

.github/workflows/zeroize.yml

@@ -46,10 +46,11 @@ jobs:
           targets: ${{ matrix.target }}
       - run: cargo build --no-default-features --target ${{ matrix.target }}
 
-  minimal-versions:
-    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
-    with:
-      working-directory: ${{ github.workflow }}
+  # TODO(tarcieri): disabled until it can be made compatible with workspace-level lints
+  #  minimal-versions:
+  #    uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
+  #    with:
+  #      working-directory: ${{ github.workflow }}
 
   test:
     strategy:

Cargo.toml

@@ -29,3 +29,42 @@ opt-level = 2
 
 [patch.crates-io]
 cmov = { path = "cmov" }
+
+[workspace.lints.clippy]
+borrow_as_ptr = "warn"
+cast_lossless = "warn"
+cast_possible_truncation = "warn"
+cast_possible_wrap = "warn"
+cast_precision_loss = "warn"
+cast_sign_loss = "warn"
+checked_conversions = "warn"
+doc_markdown = "warn"
+from_iter_instead_of_collect = "warn"
+manual_assert = "warn"
+map_unwrap_or = "warn"
+missing_errors_doc = "warn"
+missing_panics_doc = "warn"
+mod_module_files = "warn"
+must_use_candidate = "warn"
+implicit_saturating_sub = "warn"
+ptr_as_ptr = "warn"
+redundant_closure_for_method_calls = "warn"
+ref_as_ptr = "warn"
+return_self_not_must_use = "warn"
+semicolon_if_nothing_returned = "warn"
+trivially_copy_pass_by_ref = "warn"
+std_instead_of_alloc = "warn"
+std_instead_of_core = "warn"
+undocumented_unsafe_blocks = "warn"
+unnecessary_safety_comment = "warn"
+unwrap_in_result = "warn"
+unwrap_used = "warn"
+
+[workspace.lints.rust]
+missing_copy_implementations = "warn"
+missing_debug_implementations = "warn"
+missing_docs = "warn"
+trivial_casts = "warn"
+trivial_numeric_casts = "warn"
+unused_lifetimes = "warn"
+unused_qualifications = "warn"

blobby/Cargo.toml

@@ -13,3 +13,6 @@ description = "Iterator over simple binary blob storage"
 
 [features]
 alloc = []
+
+[lints]
+workspace = true

blobby/src/bin/decode.rs

@@ -1,5 +1,5 @@
 //! Encoding utility
-use std::error::Error;
+use core::error::Error;
 
 #[cfg(not(feature = "alloc"))]
 fn main() -> Result<(), Box<dyn Error>> {

blobby/src/bin/encode.rs

@@ -1,5 +1,5 @@
 //! Encoding utility
-use std::error::Error;
+use core::error::Error;
 
 #[cfg(not(feature = "alloc"))]
 fn main() -> Result<(), Box<dyn Error>> {