fix: correct position when document scrollbar is on left side with fixed strategy

DanielleHuisman · DanielleHuisman · commit f778a61c0846 · 2025-05-04T21:02:21.000+02:00
diff --git a/packages/dom/src/utils/get_rect_relative_to_offset_parent.rs b/packages/dom/src/utils/get_rect_relative_to_offset_parent.rs
@@ -32,6 +32,12 @@ pub fn get_rect_relative_to_offset_parent(
     let mut scroll = NodeScroll::new(0.0);
     let mut offsets = Coords::new(0.0);
 
+    // If the <body> scrollbar appears on the left (e.g. RTL systems).
+    // Use Firefox with layout.scrollbar.side = 3 in about:config to test this.
+    let set_left_rtl_scrollbar_offset = |offsets: &mut Coords| {
+        offsets.x = get_window_scroll_bar_x(&document_element, None);
+    };
+
     #[allow(clippy::nonminimal_bool)]
     if is_offset_parent_an_element || (!is_offset_parent_an_element && !is_fixed) {
         if get_node_name((&offset_parent).into()) != "body"
@@ -52,13 +58,15 @@ pub fn get_rect_relative_to_offset_parent(
                 offsets.y = offset_rect.y + offset_parent.client_top() as f64;
             }
             DomElementOrWindow::Window(_) => {
-                // If the <body> scrollbar appears on the left (e.g. RTL systems).
-                // Use Firefox with layout.scrollbar.side = 3 in about:config to test this.
-                offsets.x = get_window_scroll_bar_x(&document_element, None);
+                set_left_rtl_scrollbar_offset(&mut offsets);
             }
         }
     }
 
+    if is_fixed && !is_offset_parent_an_element {
+        set_left_rtl_scrollbar_offset(&mut offsets);
+    }
+
     let html_offset = if !is_offset_parent_an_element && !is_fixed {
         get_html_offset(&document_element, &scroll, None)
     } else {
