Skip to content

Commit fddc3af

Browse files
fix: convert __NONE__ project placeholder to empty string (CCExtractor#378)
- Fixes bug where selecting "No project" stored "__NONE__" instead of empty string. Added unit test for this edge case. - Fixes: CCExtractor#377
1 parent 30ea533 commit fddc3af

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

frontend/src/components/HomeComponents/Tasks/AddTaskDialog.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,9 @@ export const AddTaskdialog = ({
201201
if (value === '__CREATE_NEW__') {
202202
setIsCreatingNewProject(true);
203203
setNewTask({ ...newTask, project: '' });
204+
} else if (value === '__NONE__') {
205+
setIsCreatingNewProject(false);
206+
setNewTask({ ...newTask, project: '' });
204207
} else {
205208
setIsCreatingNewProject(false);
206209
setNewTask({ ...newTask, project: value });

frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,21 @@ describe('AddTaskDialog Component', () => {
202202
});
203203

204204
describe('Project Field', () => {
205+
test('sets project to empty string when "No project" is selected', () => {
206+
mockProps.isOpen = true;
207+
mockProps.uniqueProjects = ['Work', 'Personal'];
208+
render(<AddTaskdialog {...mockProps} />);
209+
210+
const projectSelect = screen.getByTestId('project-select');
211+
fireEvent.change(projectSelect, { target: { value: '__NONE__' } });
212+
213+
expect(mockProps.setIsCreatingNewProject).toHaveBeenCalledWith(false);
214+
expect(mockProps.setNewTask).toHaveBeenCalledWith({
215+
...mockProps.newTask,
216+
project: '',
217+
});
218+
});
219+
205220
test('updates project when user types in project field', async () => {
206221
mockProps.isOpen = true;
207222
mockProps.isCreatingNewProject = true;

0 commit comments

Comments
 (0)