Skip to content

[bsp][qemu] 适配串口v2并开启fifo#1

Closed
hydevcode wants to merge 553 commits intoRyan-CW-Code:serial_v2from
hydevcode:serial_v2
Closed

[bsp][qemu] 适配串口v2并开启fifo#1
hydevcode wants to merge 553 commits intoRyan-CW-Code:serial_v2from
hydevcode:serial_v2

Conversation

@hydevcode
Copy link
Copy Markdown
Collaborator

适配串口v2并开启fifo

GuEe-GUI and others added 30 commits February 11, 2025 14:58
PIN_NONE is '-1', is similar to '-RT_ERROR',
'-RT_EEMPTY' is better.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
rt_hw_* is use for DM and not DM, but LED only use in DM.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Documentation is provided to clarify how to write
doxygen documentation for RT-Thread. This document
is also integrated as part of RT-Thread doxygen
documentation.

An example is also provided.

The original README.md is removed and integrated into
this document.

Updated github actions for doxygen too.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
…t obtained by calling rt_object_get_information is empty, so the system cannot get up.
Add prefix "page_" to the name of pages.

Add this as a rule in guide of writing doxygen documents.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
* doxygen: add prefix for groups

Add "group_" prefix to doxygen group names. This makes
it easier to grep with group name later.

This patch only modifies the groups defined in the pathes
of INPUT of documentation/Doxyfile:

INPUT = . \
        ../src \
        ../include \
        ../components/finsh \
        ../components/drivers/include/drivers \
        ../components/drivers/clk \
        ../components/dfs/dfs_v2/src \
        ../components/dfs/dfs_v2/include

Other groups are not touched.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>

* ci: fixed error report when run file_check.py

Such as:
- "please delete extra space at the end of this line."
- "the RT-Thread error code should return negative value. e.g. return
  -RT_ERROR"

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>

---------

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
RT-Thread#9993)

* [src/ktime] fix the bug when use keil AC6 and open RT_USING_HOOKLIST and RT_USING_KTIME
* [lwp]对检查killpg的signo参数的有效性
* [bsp][wch] move ch32v307 sdk to package

* [bsp][wch] move ch32v307 sdk to package

* [bsp][wch] use a fixed version

* [bsp][wch]fix: ch32v307v-r1 build

* [bsp][wch] add yd board to ci

* [bsp][wch] revert toolchain path
RT-Thread#10001)

Add recommanded script and extension for writing doxygen comments on vscode

Signed-off-by: 1078249029 <1078249029@qq.com>
This patch modifies the original linker script provided by NXP by
adding RT-Thread related constant tables to flash.

Signed-off-by: Yilin Sun <imi415@imi.moe>
Regular macro definitions according to [1].

Note: for variadic macros such as MSH_CMD_EXPORT, we can
not use normal @param command, otherwise doxygen will
report "@param is not found in the argument list of ...".
So I just write the parameters by manual.

Link: https://rt-thread.github.io/rt-thread/page_howto_macro.html [1]

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Github CI doc_doxygen is very strict in checking the
build results, and will output failure even if there
are warnings.

In order to match CI's checks, local build scripts
are also checked more strictly to detect potential
errors and even warnings as early as possible.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Enable PORT and GPIO peripheral clocks and release resets for all
ports.

Signed-off-by: Yilin Sun <imi415@imi.moe>
Add LED blinking demo to align with other BSPs.

Signed-off-by: Yilin Sun <imi415@imi.moe>
MCXA156 series supports FPU and DSP, adding corresponding compiler
flags.

Signed-off-by: Yilin Sun <imi415@imi.moe>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented May 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@1078249029
Copy link
Copy Markdown

请问这个pr是怎么回事?XD

@hydevcode
Copy link
Copy Markdown
Collaborator Author

请问这个pr是怎么回事?XD

我这边适配qemu的串口用到了在您这个pr后面发的一个commit,然后用了rebase之后就这样了,要不您那边rebase一下,我在重新提个pr

@1078249029
Copy link
Copy Markdown

1078249029 commented May 4, 2025

请问这个pr是怎么回事?XD

我这边适配qemu的串口用到了在您这个pr后面发的一个commit,然后用了rebase之后就这样了,要不您那边rebase一下,我在重新提个pr

我不是rtt仓库的commiter,没有权限rebase😂
我记得这种情况是一个很久没有更新的pr需要新提交commit时误操作rebase导致的。可能reset --soft到提交commit之前能够解决,然后就是正常的pull上游更新然后提交你的commit,最后再rebase到主线。
而且如果只是想给rtt提交pr也不必在自己的仓库内提交pr,把commit同步到云后去rtt的仓库就可以直接提交pr了

@hydevcode
Copy link
Copy Markdown
Collaborator Author

请问这个pr是怎么回事?XD

我这边适配qemu的串口用到了在您这个pr后面发的一个commit,然后用了rebase之后就这样了,要不您那边rebase一下,我在重新提个pr

我不是rtt仓库的commiter,没有权限rebase😂 我记得这种情况是一个很久没有更新的pr需要新提交commit时误操作rebase导致的。可能reset --soft到提交commit之前能够解决,然后就是正常的pull上游更新然后提交你的commit,最后再rebase到主线。 而且如果只是想给rtt提交pr也不必在自己的仓库内提交pr,把commit同步到云后去rtt的仓库就可以直接提交pr了

额,当前这个仓库分支就是一个pr,我是想基于这个pr去追加commit,但是这个pr很久没更新了,得pull一下最新的版本,不然我这个commit追加不上去
这是这个pr的链接:RT-Thread#9389

@1078249029
Copy link
Copy Markdown

请问这个pr是怎么回事?XD

我这边适配qemu的串口用到了在您这个pr后面发的一个commit,然后用了rebase之后就这样了,要不您那边rebase一下,我在重新提个pr

我不是rtt仓库的commiter,没有权限rebase😂 我记得这种情况是一个很久没有更新的pr需要新提交commit时误操作rebase导致的。可能reset --soft到提交commit之前能够解决,然后就是正常的pull上游更新然后提交你的commit,最后再rebase到主线。 而且如果只是想给rtt提交pr也不必在自己的仓库内提交pr,把commit同步到云后去rtt的仓库就可以直接提交pr了

额,当前这个仓库分支就是一个pr,我是想基于这个pr去追加commit,但是这个pr很久没更新了,得pull一下最新的版本,不然我这个commit追加不上去 这是这个pr的链接:RT-Thread#9389

确实得pull下,里面甚至包含了我的代码😂
您这pr含金量好高,膜拜

@hydevcode hydevcode marked this pull request as draft May 4, 2025 16:31
@hydevcode
Copy link
Copy Markdown
Collaborator Author

请问这个pr是怎么回事?XD

我这边适配qemu的串口用到了在您这个pr后面发的一个commit,然后用了rebase之后就这样了,要不您那边rebase一下,我在重新提个pr

我不是rtt仓库的commiter,没有权限rebase😂 我记得这种情况是一个很久没有更新的pr需要新提交commit时误操作rebase导致的。可能reset --soft到提交commit之前能够解决,然后就是正常的pull上游更新然后提交你的commit,最后再rebase到主线。 而且如果只是想给rtt提交pr也不必在自己的仓库内提交pr,把commit同步到云后去rtt的仓库就可以直接提交pr了

额,当前这个仓库分支就是一个pr,我是想基于这个pr去追加commit,但是这个pr很久没更新了,得pull一下最新的版本,不然我这个commit追加不上去 这是这个pr的链接:RT-Thread#9389

确实得pull下,里面甚至包含了我的代码😂 您这pr含金量好高,膜拜

我这份pr是要重新提的,还没弄好,rebase误操作了,您不是也说了吗

@hydevcode hydevcode closed this May 4, 2025
@hydevcode
Copy link
Copy Markdown
Collaborator Author

请问这个pr是怎么回事?XD

我这边适配qemu的串口用到了在您这个pr后面发的一个commit,然后用了rebase之后就这样了,要不您那边rebase一下,我在重新提个pr

我不是rtt仓库的commiter,没有权限rebase😂 我记得这种情况是一个很久没有更新的pr需要新提交commit时误操作rebase导致的。可能reset --soft到提交commit之前能够解决,然后就是正常的pull上游更新然后提交你的commit,最后再rebase到主线。 而且如果只是想给rtt提交pr也不必在自己的仓库内提交pr,把commit同步到云后去rtt的仓库就可以直接提交pr了

额,当前这个仓库分支就是一个pr,我是想基于这个pr去追加commit,但是这个pr很久没更新了,得pull一下最新的版本,不然我这个commit追加不上去 这是这个pr的链接:RT-Thread#9389

#确实得pull下,里面甚至包含了我的代码😂 您这pr含金量好高,膜拜

我这份pr是要重新提的,还没弄好,rebase误操作了,您不是也说了吗

可能您误解我意思了,我指的pull意思是想让pr的作者更新一下分支的的版本,这样好追加commit ,没有要把您的代码包含之类的意思

@hydevcode
Copy link
Copy Markdown
Collaborator Author

请问这个pr是怎么回事?XD

我这边适配qemu的串口用到了在您这个pr后面发的一个commit,然后用了rebase之后就这样了,要不您那边rebase一下,我在重新提个pr

抱歉,给您造成了困扰,之前以为您是原PR的作者,非常感谢您的指正,现已经修改并重新发起pr
这是新的链接:#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.