Attempted fix for JSX comment duplication but needs refinement

Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>

Author: Copilot

.github/copilot-questions.md

@@ -1,4 +1,5 @@
-Questions I have that I think the developers of this project can help me with:
- * How does control flow analysis represent a circular graph? I checked the documentation server for "cfa" and "control flow"
- * How do I tell if a symbol is in the global scope? I checked the documentation server for topics referencing "symbol" and "global"
- * What is an `EscapedName`, exactly?
+Questions I have that I think the developers of this project can help me with:
+* How does control flow analysis represent a circular graph? I checked the documentation server for "cfa" and "control flow"
+* How do I tell if a symbol is in the global scope? I checked the documentation server for topics referencing "symbol" and "global"
+* What is an `EscapedName`, exactly?
+* How can I distinguish between trivia comments and JSX text content containing comments to prevent JSX comment duplication? I searched the documentation for "jsx" and "comment" but need to understand the emission order and when JSX text content vs trivia should take precedence.

src/compiler/emitter.ts

@@ -213,9 +213,12 @@ import {
     isInJsonFile,
     isJSDocLikeText,
     isJsonSourceFile,
-    isJsxClosingElement,
-    isJsxNamespacedName,
-    isJsxOpeningElement,
+    isJsxClosingElement,
+    isJsxElement,
+    isJsxFragment,
+    isJsxNamespacedName,
+    isJsxOpeningElement,
+    isJsxText,
     isKeyword,
     isLet,
     isLiteralExpression,
@@ -3176,7 +3179,12 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
             if (needsIndent) {
                 increaseIndent();
             }
-            emitLeadingCommentsOfPosition(startPos);
+            const isJsxExprContext = contextNode.kind === SyntaxKind.JsxExpression;
+            // Skip emitting leading comments for JSX expressions when emitting JSX children
+            // to prevent duplication with JSX text content
+            if (!(isJsxExprContext && isEmittingJsxChildren)) {
+                emitLeadingCommentsOfPosition(startPos);
+            }
             if (needsIndent) {
                 decreaseIndent();
             }
@@ -3195,13 +3203,61 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
 
         if (isSimilarNode && contextNode.end !== pos) {
             const isJsxExprContext = contextNode.kind === SyntaxKind.JsxExpression;
-            emitTrailingCommentsOfPosition(pos, /*prefixSpace*/ !isJsxExprContext, /*forceNoNewline*/ isJsxExprContext);
+            // Skip emitting trailing comments for JSX expressions when emitting JSX children
+            // to prevent duplication with JSX text content
+            if (!(isJsxExprContext && isEmittingJsxChildren)) {
+                emitTrailingCommentsOfPosition(pos, /*prefixSpace*/ !isJsxExprContext, /*forceNoNewline*/ isJsxExprContext);
+            }
         }
         return pos;
     }
 
-    function commentWillEmitNewLine(node: CommentRange) {
-        return node.kind === SyntaxKind.SingleLineCommentTrivia || !!node.hasTrailingNewLine;
+    function commentWillEmitNewLine(node: CommentRange) {
+        return node.kind === SyntaxKind.SingleLineCommentTrivia || !!node.hasTrailingNewLine;
+    }
+
+    function jsxExpressionCommentsOverlapWithJsxText(jsxExpr: JsxExpression): boolean {
+        if (!isEmittingJsxChildren || !currentSourceFile) return false;
+        
+        // Check if this JSX expression is a child of a JSX element
+        const parent = jsxExpr.parent;
+        if (!parent || (!isJsxElement(parent) && !isJsxFragment(parent))) {
+            return false;
+        }
+        
+        const children = parent.children;
+        const exprIndex = children.indexOf(jsxExpr);
+        if (exprIndex === -1) return false;
+        
+        // Check trailing comments that might overlap with next JSX text
+        const trailingComments = getTrailingCommentRanges(currentSourceFile.text, jsxExpr.end);
+        if (trailingComments && exprIndex + 1 < children.length) {
+            const nextChild = children[exprIndex + 1];
+            if (isJsxText(nextChild)) {
+                // Check if any trailing comment overlaps with the next JSX text node
+                for (const comment of trailingComments) {
+                    if (comment.pos >= nextChild.pos && comment.end <= nextChild.end) {
+                        return true;
+                    }
+                }
+            }
+        }
+        
+        // Check leading comments that might overlap with previous JSX text
+        const leadingComments = getLeadingCommentRanges(currentSourceFile.text, jsxExpr.pos);
+        if (leadingComments && exprIndex > 0) {
+            const prevChild = children[exprIndex - 1];
+            if (isJsxText(prevChild)) {
+                // Check if any leading comment overlaps with the previous JSX text node
+                for (const comment of leadingComments) {
+                    if (comment.pos >= prevChild.pos && comment.end <= prevChild.end) {
+                        return true;
+                    }
+                }
+            }
+        }
+        
+        return false;
     }
 
     function willEmitLeadingNewLine(node: Expression): boolean {