Skip to content

Commit f97a81c

Browse files
authored
Revert "[Sandbox SQL snapshot] Pin org.opensearch.query:* (unified-query-*) snapshots to mavenLocal (opensearch-project#21578)" (opensearch-project#21580)
This reverts commit 36809cc. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
1 parent 4d40eb8 commit f97a81c

4 files changed

Lines changed: 4 additions & 52 deletions

File tree

sandbox/build.gradle

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -46,34 +46,11 @@ subprojects {
4646
// The patched calcite-core / calcite-linq4j live in the OpenSearch
4747
// snapshots Maven repo; analytics-framework advertises them as `api`,
4848
// so every consumer of analytics-framework needs both the repo and a
49-
// `force` to win over transitive vanilla calcite.
50-
//
51-
// org.opensearch.query (unified-query-*) is excluded from this remote and
52-
// pinned to mavenLocal in the consuming subprojects (see analytics-engine
53-
// and test-ppl-frontend build.gradle). The remote OpenSearch Snapshots repo
54-
// only republishes from sql/main, not from sql/feature/mustang-ppl-integration,
55-
// so its 3.7.0.0-SNAPSHOT jars trail the feature branch by however many merges.
56-
// Gradle's default SNAPSHOT resolution weighs the remote's explicit
57-
// <buildNumber>/timestamp metadata higher than mavenLocal's <localCopy>true>,
58-
// so the stale remote wins even when mavenLocal has a newer <lastUpdated>.
59-
// Excluding the group here forces gradle to fall through to mavenLocal,
60-
// populated by the sandbox-check workflow's pre-step
61-
// (publishUnifiedQueryPublicationToMavenLocal from the feature branch).
62-
// Drop this exclusion once the SQL feature branch merges to sql/main and
63-
// remote snapshots catch up.
49+
// `force` to win over transitive vanilla calcite
6450
repositories {
65-
// mavenLocal serves org.opensearch.query:* (unified-query-*) only — the
66-
// sandbox-check workflow's pre-step populates it from the SQL feature branch
67-
// (publishUnifiedQueryPublicationToMavenLocal). Restricting via includeGroup
68-
// keeps mavenLocal off the resolution path for everything else, where it
69-
// would otherwise mask intentionally-pinned remote artifacts.
70-
mavenLocal {
71-
mavenContent { includeGroup 'org.opensearch.query' }
72-
}
7351
maven {
7452
name = 'OpenSearch Snapshots'
7553
url = 'https://ci.opensearch.org/ci/dbc/snapshots/maven/'
76-
mavenContent { excludeGroup 'org.opensearch.query' }
7754
}
7855
}
7956

sandbox/plugins/analytics-backend-datafusion/build.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ repositories {
1616
maven {
1717
name = 'OpenSearch Snapshots'
1818
url = 'https://ci.opensearch.org/ci/dbc/snapshots/maven/'
19-
// unified-query-* artifacts are pinned to mavenLocal — see comment in
20-
// sandbox/build.gradle's subprojects { repositories } block.
21-
mavenContent { excludeGroup 'org.opensearch.query' }
2219
}
2320
}
2421

sandbox/plugins/analytics-engine/build.gradle

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,8 @@
1414

1515
apply plugin: 'opensearch.internal-cluster-test'
1616

17-
// SQL Unified Query API version (aligned with OpenSearch build version).
18-
// Bumped to 3.7 to match the rest of the sandbox (test-ppl-frontend declares
19-
// the same '3.7.0.0-SNAPSHOT'). org.opensearch.query:* is also pinned to
20-
// mavenLocal in sandbox/build.gradle's subprojects { repositories } block,
21-
// so the remote OpenSearch Snapshots repo no longer serves this group;
22-
// 3.6 jars don't exist in mavenLocal (only 3.7 from the feature branch's
23-
// publishUnifiedQueryPublicationToMavenLocal pre-step), so the older pin
24-
// caused `Could not find org.opensearch.query:unified-query-api:3.6.0.0-SNAPSHOT`
25-
// at internal-cluster-test resolution.
26-
def sqlUnifiedQueryVersion = '3.7.0.0-SNAPSHOT'
17+
// SQL Unified Query API version (aligned with OpenSearch build version)
18+
def sqlUnifiedQueryVersion = '3.6.0.0-SNAPSHOT'
2719

2820
opensearchplugin {
2921
description = 'Analytics engine hub: discovers and wires query extensions via ExtensiblePlugin SPI.'

sandbox/plugins/test-ppl-frontend/build.gradle

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,24 +32,10 @@ opensearchplugin {
3232
}
3333

3434
repositories {
35-
// Pin org.opensearch.query:* (unified-query-*) artifacts to mavenLocal only.
36-
// The remote OpenSearch Snapshots repo only republishes from sql/main, not from
37-
// sql/feature/mustang-ppl-integration, so its 3.7.0.0-SNAPSHOT jars trail the
38-
// feature branch by however many merges. Gradle's default SNAPSHOT resolution
39-
// weighs the remote's explicit <buildNumber>/timestamp metadata higher than
40-
// mavenLocal's bare <localCopy>true>, so the stale remote wins even when
41-
// mavenLocal has a newer <lastUpdated>. Restrict the unified-query group to
42-
// mavenLocal and exclude it from the remote so the sandbox-check workflow's
43-
// pre-step (publishUnifiedQueryPublicationToMavenLocal from the feature branch)
44-
// is the authoritative source. Drop this filter once SQL feature branch merges
45-
// to sql/main and remote snapshots catch up.
46-
mavenLocal {
47-
mavenContent { includeGroup 'org.opensearch.query' }
48-
}
35+
mavenLocal()
4936
maven {
5037
name = 'OpenSearch Snapshots'
5138
url = 'https://ci.opensearch.org/ci/dbc/snapshots/maven/'
52-
mavenContent { excludeGroup 'org.opensearch.query' }
5339
}
5440
}
5541

0 commit comments

Comments
 (0)