Skip to content

Commit 295c49a

Browse files
committed
chen - alphabetical order of o_f return
Signed-off-by: Jialiang Liang <jiallian@amazon.com>
1 parent 081f44a commit 295c49a

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

core/src/main/java/org/opensearch/sql/expression/function/udf/RexOffsetFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public static String calculateOffsets(String text, String patternStr) {
8484
groupIndex++;
8585
}
8686

87-
java.util.Collections.reverse(offsetPairs);
87+
java.util.Collections.sort(offsetPairs);
8888
return offsetPairs.isEmpty() ? null : String.join("&", offsetPairs);
8989
} catch (PatternSyntaxException e) {
9090
throw new IllegalArgumentException(

core/src/test/java/org/opensearch/sql/expression/function/udf/RexOffsetFunctionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public void testCalculateOffsetsWithMultipleNamedGroups() {
2828
String text = "SMITH";
2929
String pattern = "(?<first>[A-Z])(?<rest>[A-Z]+)";
3030
String result = RexOffsetFunction.calculateOffsets(text, pattern);
31-
assertEquals("rest=1-4&first=0-0", result);
31+
assertEquals("first=0-0&rest=1-4", result);
3232
}
3333

3434
@Test
@@ -70,7 +70,7 @@ public void testCalculateOffsetsWithComplexPattern() {
7070
String text = "ABC123DEF";
7171
String pattern = "(?<letters>[A-Z]+)(?<numbers>[0-9]+)(?<moreletters>[A-Z]+)";
7272
String result = RexOffsetFunction.calculateOffsets(text, pattern);
73-
assertEquals("moreletters=6-8&numbers=3-5&letters=0-2", result);
73+
assertEquals("letters=0-2&moreletters=6-8&numbers=3-5", result);
7474
}
7575

7676
@Test

0 commit comments

Comments
 (0)