Skip to content

Commit bde4fc3

Browse files
committed
comment - remove unused fn for string converting
Signed-off-by: Jialiang Liang <jiallian@amazon.com>
1 parent fa0f956 commit bde4fc3

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

core/src/main/java/org/opensearch/sql/expression/parse/RegexCommonUtils.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
import java.util.regex.Matcher;
1212
import java.util.regex.Pattern;
1313
import java.util.regex.PatternSyntaxException;
14-
import org.opensearch.sql.data.model.ExprValue;
15-
import org.opensearch.sql.data.type.ExprCoreType;
1614

1715
/**
1816
* Common utilities for regex operations. Provides pattern caching and consistent matching behavior.
@@ -103,23 +101,4 @@ public static String extractNamedGroup(String text, Pattern pattern, String grou
103101

104102
return null;
105103
}
106-
107-
/**
108-
* Convert ExprValue to string, handling non-string types. Based on decision to auto-convert
109-
* non-string fields to strings.
110-
*
111-
* @param value The ExprValue to convert
112-
* @return String representation of the value
113-
*/
114-
public static String toStringValue(ExprValue value) {
115-
if (value == null || value.isNull() || value.isMissing()) {
116-
return null;
117-
}
118-
119-
if (value.type() == ExprCoreType.STRING) {
120-
return value.stringValue();
121-
}
122-
123-
return value.value().toString();
124-
}
125104
}

0 commit comments

Comments
 (0)