Skip to content

Commit f19e1d9

Browse files
committed
spotless: rewrap predicate JavaDoc
Signed-off-by: Jialiang Liang <jiallian@amazon.com>
1 parent 15c52f7 commit f19e1d9

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVisitor.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2221,14 +2221,14 @@ private RelNode rewriteWindowAsAggregateJoin(Window node, CalcitePlanContext con
22212221
/**
22222222
* Returns true if {@code node} matches the shape PPL {@code eventstats} actually emits — all
22232223
* window functions resolve to a windowable aggregation (present in both {@link
2224-
* BuiltinFunctionName#ofWindowFunction} and {@link BuiltinFunctionName#ofAggregation}), no
2225-
* {@code ORDER BY}, default frame, and all partition keys are simple (non-dotted) field
2226-
* references. Anything outside that shape falls through to the legacy {@code RexOver} lowering,
2227-
* preserving existing behavior — including the {@code Unexpected window function} error for
2228-
* non-windowable aggregates like {@code percentile} (window-map miss), the legacy {@code
2229-
* ROW_NUMBER} window form (aggregation-map miss), {@code dc} / {@code distinct_count} which are
2230-
* only registered under their window names, and dotted-path BY keys (e.g. {@code by
2231-
* doc.user.city}) which would need nested-field resolution in the join condition.
2224+
* BuiltinFunctionName#ofWindowFunction} and {@link BuiltinFunctionName#ofAggregation}), no {@code
2225+
* ORDER BY}, default frame, and all partition keys are simple (non-dotted) field references.
2226+
* Anything outside that shape falls through to the legacy {@code RexOver} lowering, preserving
2227+
* existing behavior — including the {@code Unexpected window function} error for non-windowable
2228+
* aggregates like {@code percentile} (window-map miss), the legacy {@code ROW_NUMBER} window form
2229+
* (aggregation-map miss), {@code dc} / {@code distinct_count} which are only registered under
2230+
* their window names, and dotted-path BY keys (e.g. {@code by doc.user.city}) which would need
2231+
* nested-field resolution in the join condition.
22322232
*
22332233
* <p>PPL's {@code AstExpressionBuilder.visitWindowFunction} wraps the parsed function in a {@link
22342234
* WindowFunction} whose inner expression is a {@link Function} (not {@link AggregateFunction}) —
@@ -2281,8 +2281,8 @@ private static String extractAggregateFunctionName(UnresolvedExpression fn) {
22812281

22822282
/**
22832283
* A bare, simple (non-dotted) field reference. Dotted paths like {@code doc.user.city} are
2284-
* rejected here because the join condition references the partition key by field name via
2285-
* {@code relBuilder.field(2, side, name)}, which does not perform nested-field resolution.
2284+
* rejected here because the join condition references the partition key by field name via {@code
2285+
* relBuilder.field(2, side, name)}, which does not perform nested-field resolution.
22862286
*/
22872287
private static boolean isBareFieldReference(UnresolvedExpression expr) {
22882288
if (expr instanceof Field f) {

0 commit comments

Comments
 (0)