DataType GetByName reduced memory allocations by switching from string to span.

Author: RyanLamansky

SqlServerSimulator/DataType.cs

@@ -42,8 +42,8 @@ private protected DataType()
     /// <exception cref="SimulatedSqlException">Column, parameter, or variable #<paramref name="index"/>: Cannot find data type <paramref name="name"/>.</exception>
     public static DataType GetByName(Name name, int index)
     {
-        Span<char> upper = stackalloc char[name.Value.Length];
-        return name.Value.ToUpperInvariant(upper) switch
+        Span<char> upper = stackalloc char[name.Span.Length];
+        return name.Span.ToUpperInvariant(upper) switch
         {
             3 => upper switch
             {
@@ -62,7 +62,7 @@ public static DataType GetByName(Name name, int index)
                 _ => null
             },
             _ => null,
-        } ?? throw SimulatedSqlException.CannotFindDataType(name.Value, index);
+        } ?? throw SimulatedSqlException.CannotFindDataType(name.Span, index);
     }
 
     public static DataType GetByDbType(DbType dbType) => dbType switch

SqlServerSimulator/SimulatedSqlException.cs

@@ -90,7 +90,7 @@ private SimulatedSqlException(string? message, params ReadOnlySpan<SimulatedSqlE
     /// <param name="name">The name of the type.</param>
     /// <param name="index">The 1-based index of the reference.</param>
     /// <returns>The exception.</returns>
-    internal static SimulatedSqlException CannotFindDataType(string name, int index) => new($"Column, parameter, or variable #{index}: Cannot find data type {name}.", 2715, 16, 6);
+    internal static SimulatedSqlException CannotFindDataType(ReadOnlySpan<char> name, int index) => new($"Column, parameter, or variable #{index}: Cannot find data type {name}.", 2715, 16, 6);
 
     /// <summary>
     /// Mimics the SqlException that occurs then when a TOP/OFFSET/FETCH clause has an inappropriate column reference.