RyanLamansky
diff --git a/‎CLAUDE.md‎
Lines changed: 3 additions & 1 deletion b/‎CLAUDE.md‎
Lines changed: 3 additions & 1 deletion
diff --git a/‎SqlServerSimulator.Tests/DdlTriggerTests.cs‎
Lines changed: 96 additions & 0 deletions b/‎SqlServerSimulator.Tests/DdlTriggerTests.cs‎
Lines changed: 96 additions & 0 deletions
diff --git a/‎SqlServerSimulator.Tests/PermissionStatementTests.cs‎
Lines changed: 160 additions & 0 deletions b/‎SqlServerSimulator.Tests/PermissionStatementTests.cs‎
Lines changed: 160 additions & 0 deletions
@@ -158,8 +158,10 @@ Per-feature deep-dives live under `docs/claude/`. Each entry below is a trigger:
 - **Touching table hints (`WITH (NOLOCK [, …])` on FROM sources / JOIN-RHS / UPDATE / DELETE targets, the legacy `(hint)` without-WITH form, `Msg 321` unknown-hint rejection), statement-level `OPTION (…)` hints (`RECOMPILE` / `MAXDOP` / `FAST` / `LOOP|HASH|MERGE JOIN` / `FORCE ORDER` / `OPTIMIZE FOR (UNKNOWN)` / `USE HINT(…)` / `MAXRECURSION` with its CTE-binding override), the `TableHintNames` / `OptionHintFirstWords` closed accept-lists, or `SkipBalancedParens` argument consumption** → [`docs/claude/query-hints.md`](docs/claude/query-hints.md).
 - **Touching the `LockResource` / `LockManager` pair, the 8-mode compatibility matrix (Sch-S / Sch-M / IS / IX / SIX / S / U / X), `BatchContext.AcquireStatementLock` / `AcquireTransactionLock` / `AcquireDataLockIfApplicable` / `AcquireRowLockTxScoped` / `TouchRowForRead` / `WrapWithRowConflictChecks` / `ResolveSnapshotXidForRead`, the `DataLockPlan` struct that captures the per-row strategy, the row-lock dict on `HeapTable.RowLocks`, lock escalation (5000-threshold via `SimulatedDbTransaction.RowLockCountsByTable` + `EscalatedTables`), `SimulatedDbConnection.SessionIsolationLevel` + `SET TRANSACTION ISOLATION LEVEL` wiring, the hint surface (UPDLOCK / XLOCK / READPAST / TABLOCK / TABLOCKX / HOLDLOCK / SERIALIZABLE / REPEATABLEREAD / NOLOCK), `SimulatedDbConnection.Spid` / `LockTimeoutMillis` / `CurrentExecutingThreadId` / `WaitingOnResource`, the same-thread-deadlock check and cross-thread waiter-graph cycle detection (Msg 1205, auto-rollback of victim's tx), the lock-timeout path (Msg 1222), or the SNAPSHOT + RCSI machinery (`Database.AllowSnapshotIsolation` / `ReadCommittedSnapshot` / `AllocateTransactionCommitId`, `HeapTable.RowVersions` + `RowVersionChain` + `HistoricalVersion`, the `VersionStore` static helper for `CaptureWrite` / `FinalizePendingEntries` / `DiscardPendingEntries` / `ResolveVisibleVersion` / `CheckSnapshotUpdateConflict`, `SimulatedDbTransaction.SnapshotXid` / `PendingVersionEntries`, `BatchContext.RcsiStatementSnapshotXid`, `ALTER DATABASE … SET (ALLOW_SNAPSHOT_ISOLATION | READ_COMMITTED_SNAPSHOT)`, Msg 3952 + Msg 3960, `VersionStore.RunGarbageCollection` + `Database.ActiveSnapshotTxs`, or the `sys.dm_tran_version_store` / `sys.dm_tran_version_store_space_usage` / `sys.dm_tran_active_snapshot_database_transactions` DMVs via `VersionStoreDmvs`)** → [`docs/claude/locking.md`](docs/claude/locking.md).
 - **Touching `hierarchyid` (the `HierarchyIdSqlType` storage + segment-array `int[][]` internal representation in `Storage/HierarchyIdType.cs`, the `SqlValue.FromHierarchyId` / `AsHierarchyId` accessors, the `hierarchyid::Parse` / `hierarchyid::GetRoot` static-call dispatch in `HierarchyIdStaticCall`, the `.GetLevel` / `.GetAncestor` / `.GetDescendant` / `.IsDescendantOf` / `.ToString` instance-method dispatch in `HierarchyIdMethodCall`, the Msg 6522 verbatim wording in `SimulatedSqlException.TypeErrors.cs`, the `:` / `.<method>(` parser cases in `Expression.cs`, or the `sys.types` row shape — system_type_id 240, user_type_id 128, max_length 892)** → [`docs/claude/bacpac-prerequisites.md`](docs/claude/bacpac-prerequisites.md) (the `hierarchyid` section carries the implementation detail; the byte-identical-CAST gap is deferred to the BACPAC loader bundle).
+- **Touching `CREATE TRIGGER … ON DATABASE` / `DROP TRIGGER … ON DATABASE`, the `DdlTrigger` class + `Database.DdlTriggers` dict, the `sys.triggers` row shape for DDL triggers (parent_class=0, parent_class_desc='DATABASE', parent_id=0), or the no-fire deferral (DDL events aren't dispatched to a trigger loop)** → [`docs/claude/bacpac-prerequisites.md`](docs/claude/bacpac-prerequisites.md) (the "DDL trigger" section carries the implementation detail).
+- **Touching `GRANT` / `REVOKE` / `DENY` parsing (including `WITH GRANT OPTION`, `REVOKE GRANT OPTION FOR`, `CASCADE`, `ON OBJECT::name` / `SCHEMA::name` / `DATABASE::name` / `TYPE::name`), the principal DDL surface (`CREATE USER`, `CREATE ROLE`, `ALTER ROLE … {ADD | DROP} MEMBER`, `DROP USER`, `DROP ROLE`), the `DatabasePrincipal` / `DatabasePermission` classes + `Database.Principals` / `Database.Permissions` / `Database.RoleMembers`, the pre-seeded fixed principals (public=0 / dbo=1 / guest=2 / INFORMATION_SCHEMA=3 / sys=4), the `sys.database_principals` / `sys.database_permissions` / `sys.database_role_members` catalog views, the Msg 15151 unknown-principal verbatim wording, or the Msg 15023 duplicate-principal-name verbatim wording** → [`docs/claude/bacpac-prerequisites.md`](docs/claude/bacpac-prerequisites.md) (the "Permission statements" section carries the implementation detail).
 - **Adding a new top-level statement parser or changing the dispatch loop's statement-separator rules** → [`docs/claude/grammar.md`](docs/claude/grammar.md) + [`docs/claude/control-flow.md`](docs/claude/control-flow.md).
-- **Working on BACPAC import support (the eventual `Simulation.FromBacpac` / `FromBacPac` entry point), or knocking off any of its remaining prerequisite features (DDL triggers `ON DATABASE`, permission statements `GRANT`/`REVOKE`/`DENY`, `xml` + XML schema collections + XML methods + XML indexes, `geography`/`geometry` spatial types, full-text catalog/index + `CONTAINS`/`FREETEXT`)** → [`docs/claude/bacpac-prerequisites.md`](docs/claude/bacpac-prerequisites.md). Working document with a feature checklist + the BCP wire-format type matrix; serves as the running scoping doc until the loader baseline lands. Shipped prerequisites: UDDTs / alias types, `sp_addextendedproperty` + `sys.extended_properties`, ALTER DATABASE options accept-list, hierarchyid AW-minimum-viable surface.
+- **Working on BACPAC import support (the eventual `Simulation.FromBacpac` / `FromBacPac` entry point), or knocking off any of its remaining prerequisite features (`xml` + XML schema collections + XML methods + XML indexes, `geography`/`geometry` spatial types, full-text catalog/index + `CONTAINS`/`FREETEXT`)** → [`docs/claude/bacpac-prerequisites.md`](docs/claude/bacpac-prerequisites.md). Working document with a feature checklist + the BCP wire-format type matrix; serves as the running scoping doc until the loader baseline lands. Shipped prerequisites: UDDTs / alias types, `sp_addextendedproperty` + `sys.extended_properties`, ALTER DATABASE options accept-list, hierarchyid AW-minimum-viable surface, DDL trigger `ON DATABASE`, GRANT/REVOKE/DENY + CREATE USER/CREATE ROLE/ALTER ROLE/DROP USER/DROP ROLE + `sys.database_principals` / `sys.database_permissions` / `sys.database_role_members`.
 
 ## Not modeled
 
 
@@ -0,0 +1,96 @@
+using static Microsoft.VisualStudio.TestTools.UnitTesting.Assert;
+
+namespace SqlServerSimulator;
+
+/// <summary>
+/// Behavioral tests for database-scope DDL triggers
+/// (<c>CREATE TRIGGER … ON DATABASE FOR &lt;event_type_group&gt; AS &lt;body&gt;</c>).
+/// The simulator stores DDL triggers for catalog-view round-trip but does
+/// not fire them; these tests verify the storage + catalog visibility +
+/// drop / disable paths.
+/// </summary>
+[TestClass]
+public sealed class DdlTriggerTests
+{
+    private const string CreateAwTrigger = """
+        create trigger [ddlDatabaseTriggerLog]
+        on database
+        for ddl_database_level_events as
+        begin
+            set nocount on;
+        end
+        """;
+
+    [TestMethod]
+    public void CreateTrigger_OnDatabase_Succeeds()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery(CreateAwTrigger);
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.triggers where name = 'ddlDatabaseTriggerLog'"));
+    }
+
+    [TestMethod]
+    public void DdlTrigger_SysTriggersRow_HasDatabaseParentClass()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery(CreateAwTrigger);
+        AreEqual((byte)0, sim.ExecuteScalar("select parent_class from sys.triggers where name = 'ddlDatabaseTriggerLog'"));
+        AreEqual("DATABASE", sim.ExecuteScalar("select parent_class_desc from sys.triggers where name = 'ddlDatabaseTriggerLog'"));
+        AreEqual(0, sim.ExecuteScalar("select parent_id from sys.triggers where name = 'ddlDatabaseTriggerLog'"));
+        AreEqual("SQL_TRIGGER", sim.ExecuteScalar("select type_desc from sys.triggers where name = 'ddlDatabaseTriggerLog'"));
+        IsFalse((bool)sim.ExecuteScalar("select is_instead_of_trigger from sys.triggers where name = 'ddlDatabaseTriggerLog'")!);
+        IsFalse((bool)sim.ExecuteScalar("select is_disabled from sys.triggers where name = 'ddlDatabaseTriggerLog'")!);
+    }
+
+    [TestMethod]
+    public void DropTrigger_OnDatabase_RemovesFromCatalog()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery(CreateAwTrigger);
+        _ = sim.ExecuteNonQuery("drop trigger [ddlDatabaseTriggerLog] on database");
+        AreEqual(0, sim.ExecuteScalar("select count(*) from sys.triggers where name = 'ddlDatabaseTriggerLog'"));
+    }
+
+    [TestMethod]
+    public void DropTrigger_OnDatabase_IfExists_SilentOnMissing()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("drop trigger if exists [missingDdlTrigger] on database");
+        AreEqual(0, sim.ExecuteScalar("select count(*) from sys.triggers where name = 'missingDdlTrigger'"));
+    }
+
+    [TestMethod]
+    public void CreateTrigger_MultiEvent_StoresAllEventTypes()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("""
+            create trigger [multiEvent]
+            on database
+            for create_table, drop_table, alter_table as
+            begin set nocount on; end
+            """);
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.triggers where name = 'multiEvent'"));
+    }
+
+    [TestMethod]
+    public void CreateTrigger_OnDatabase_AlreadyExists_Raises2714()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery(CreateAwTrigger);
+        _ = sim.AssertSqlError(CreateAwTrigger, 2714);
+    }
+
+    [TestMethod]
+    public void CreateOrAlterTrigger_OnDatabase_UpsertsBody()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery(CreateAwTrigger);
+        _ = sim.ExecuteNonQuery("""
+            create or alter trigger [ddlDatabaseTriggerLog]
+            on database
+            for ddl_table_events as
+            begin set nocount on; end
+            """);
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.triggers where name = 'ddlDatabaseTriggerLog'"));
+    }
+}
@@ -0,0 +1,160 @@
+using static Microsoft.VisualStudio.TestTools.UnitTesting.Assert;
+
+namespace SqlServerSimulator;
+
+/// <summary>
+/// Behavioral tests for <c>GRANT</c> / <c>REVOKE</c> / <c>DENY</c> + the
+/// principal DDL (<c>CREATE USER</c>, <c>CREATE ROLE</c>,
+/// <c>ALTER ROLE … ADD MEMBER</c>, <c>DROP USER</c>, <c>DROP ROLE</c>).
+/// The simulator stores parsed permissions and principals for catalog-view
+/// round-trip; no enforcement is performed.
+/// </summary>
+[TestClass]
+public sealed class PermissionStatementTests
+{
+    [TestMethod]
+    public void Grant_AwShape_ToPublic_LandsInCatalog()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("grant view any column encryption key definition to public");
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.database_permissions where permission_name = 'VIEW ANY COLUMN ENCRYPTION KEY DEFINITION'"));
+        AreEqual("GRANT", sim.ExecuteScalar("select state_desc from sys.database_permissions where permission_name = 'VIEW ANY COLUMN ENCRYPTION KEY DEFINITION'"));
+        AreEqual(0, sim.ExecuteScalar("select cast(class as int) from sys.database_permissions where permission_name = 'VIEW ANY COLUMN ENCRYPTION KEY DEFINITION'"));
+        // Grantee = public (principal_id 0, pre-seeded)
+        AreEqual(0, sim.ExecuteScalar("select grantee_principal_id from sys.database_permissions where permission_name = 'VIEW ANY COLUMN ENCRYPTION KEY DEFINITION'"));
+    }
+
+    [TestMethod]
+    public void Grant_SelectOnTable_StoresObjectScope()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("""
+            create table t (id int);
+            grant select on t to public
+            """);
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.database_permissions where permission_name = 'SELECT'"));
+    }
+
+    [TestMethod]
+    public void Revoke_RemovesPriorGrant()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("""
+            grant view any column master key definition to public;
+            revoke view any column master key definition from public;
+            """);
+        AreEqual(0, sim.ExecuteScalar("select count(*) from sys.database_permissions where permission_name = 'VIEW ANY COLUMN MASTER KEY DEFINITION'"));
+    }
+
+    [TestMethod]
+    public void Deny_StoresWithDenyState()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("deny view any column master key definition to public");
+        AreEqual("DENY", sim.ExecuteScalar("select state_desc from sys.database_permissions where permission_name = 'VIEW ANY COLUMN MASTER KEY DEFINITION'"));
+    }
+
+    [TestMethod]
+    public void Grant_WithGrantOption_StoresWState()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("grant view any column master key definition to public with grant option");
+        AreEqual("GRANT_WITH_GRANT_OPTION", sim.ExecuteScalar("select state_desc from sys.database_permissions where permission_name = 'VIEW ANY COLUMN MASTER KEY DEFINITION'"));
+    }
+
+    [TestMethod]
+    public void Grant_UnknownPrincipal_Raises15151()
+        => new Simulation().AssertSqlError("grant select to no_such_principal", 15151);
+
+    [TestMethod]
+    public void CreateUser_StoresInPrincipalsDict()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("create user alice");
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.database_principals where name = 'alice'"));
+        AreEqual("SQL_USER", sim.ExecuteScalar("select type_desc from sys.database_principals where name = 'alice'"));
+    }
+
+    [TestMethod]
+    public void CreateRole_StoresInPrincipalsDict()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("create role data_reader");
+        AreEqual("DATABASE_ROLE", sim.ExecuteScalar("select type_desc from sys.database_principals where name = 'data_reader'"));
+    }
+
+    [TestMethod]
+    public void CreateUser_Duplicate_Raises15023()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("create user alice");
+        _ = sim.AssertSqlError("create user alice", 15023);
+    }
+
+    [TestMethod]
+    public void AlterRole_AddMember_LandsInRoleMembersView()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("""
+            create user alice;
+            create role data_reader;
+            alter role data_reader add member alice;
+            """);
+        AreEqual(1, sim.ExecuteScalar("""
+            select count(*)
+            from sys.database_role_members rm
+            join sys.database_principals r on r.principal_id = rm.role_principal_id
+            join sys.database_principals m on m.principal_id = rm.member_principal_id
+            where r.name = 'data_reader' and m.name = 'alice'
+            """));
+    }
+
+    [TestMethod]
+    public void DropUser_RemovesFromCatalog()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("""
+            create user alice;
+            drop user alice;
+            """);
+        AreEqual(0, sim.ExecuteScalar("select count(*) from sys.database_principals where name = 'alice'"));
+    }
+
+    [TestMethod]
+    public void DropUser_IfExists_SilentOnMissing()
+        => AreEqual(0, new Simulation().ExecuteScalar("drop user if exists alice; select count(*) from sys.database_principals where name = 'alice'"));
+
+    [TestMethod]
+    public void DropRole_CascadeDropsMembership()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("""
+            create user alice;
+            create role data_reader;
+            alter role data_reader add member alice;
+            drop role data_reader
+            """);
+        AreEqual(0, sim.ExecuteScalar("select count(*) from sys.database_role_members"));
+    }
+
+    [TestMethod]
+    public void SysDatabasePrincipals_HasFixedPrincipalsPreSeeded()
+    {
+        var sim = new Simulation();
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.database_principals where name = 'public' and is_fixed_role = 1"));
+        AreEqual(1, sim.ExecuteScalar("select count(*) from sys.database_principals where name = 'dbo'"));
+        AreEqual(0, sim.ExecuteScalar("select principal_id from sys.database_principals where name = 'public'"));
+        AreEqual(1, sim.ExecuteScalar("select principal_id from sys.database_principals where name = 'dbo'"));
+    }
+
+    [TestMethod]
+    public void Grant_MultiplePermissionsCommaList_StoresEach()
+    {
+        var sim = new Simulation();
+        _ = sim.ExecuteNonQuery("""
+            create table t (id int);
+            grant select, update, delete on t to public
+            """);
+        AreEqual(3, sim.ExecuteScalar("select count(*) from sys.database_permissions where grantee_principal_id = 0 and class = 1"));
+    }
+}