Improved test code density with DataRow.

Author: RyanLamansky

SqlServerSimulator.Tests/InsertTests.cs

@@ -13,14 +13,18 @@ public class InsertTests
     );
 
     [TestMethod]
-    public void InsertWithoutColumnNames()
+    [DataRow("create table t ( v int );insert t values ( 1 )", 1)]
+    [DataRow("create table t ( v int );insert T values ( 1 )", 1)]
+    [DataRow("create table t ( v int );insert t ( v ) values ( 1 )", 1)]
+    [DataRow("create table t ( v int );insert t ( V ) values ( 1 )", 1)]
+    public void Insert(string commandText, int expectedRecordsAffected)
     {
         var result = new Simulation()
             .CreateOpenConnection()
-            .CreateCommand("create table t ( v int );insert t values ( 1 )")
+            .CreateCommand(commandText)
             .ExecuteNonQuery();
 
-        Assert.AreEqual(1, result);
+        Assert.AreEqual(expectedRecordsAffected, result);
     }
 
     [TestMethod]
@@ -41,39 +45,6 @@ public void InsertParameterized()
         .ExecuteNonQuery()
     );
 
-    [TestMethod]
-    public void InsertWithoutColumnNamesCaseInsensitive()
-    {
-        var result = new Simulation()
-            .CreateOpenConnection()
-            .CreateCommand("create table t ( v int );insert T values ( 1 )")
-            .ExecuteNonQuery();
-
-        Assert.AreEqual(1, result);
-    }
-
-    [TestMethod]
-    public void InsertWithColumnNames()
-    {
-        var result = new Simulation()
-            .CreateOpenConnection()
-            .CreateCommand("create table t ( v int );insert t ( v ) values ( 1 )")
-            .ExecuteNonQuery();
-
-        Assert.AreEqual(1, result);
-    }
-
-    [TestMethod]
-    public void InsertWithColumnNamesCaseInsensitive()
-    {
-        var result = new Simulation()
-            .CreateOpenConnection()
-            .CreateCommand("create table t ( v int );insert t ( V ) values ( 1 )")
-            .ExecuteNonQuery();
-
-        Assert.AreEqual(1, result);
-    }
-
     [TestMethod]
     public void InsertRequiresValidColumnNames() => Assert.Throws<DbException>(() => new Simulation()
         .CreateOpenConnection()

SqlServerSimulator.Tests/SelectTests.cs

@@ -24,38 +24,23 @@ public void Select1ViaExecuteReaderIndexer()
     public void Select1ViaExecuteReaderGetInt32()
         => Assert.AreEqual(1, ScalarViaReaderTest("select 1").GetInt32(0));
 
-    private static void VersionTest(string commandText) =>
-        Assert.AreEqual("SQL Server Simulator", new Simulation().ExecuteScalar(commandText));
-
-    [TestMethod]
-    public void SelectVersion() => VersionTest("SELECT @@VERSION");
-
-    [TestMethod]
-    public void SelectVersion_LowerCase() => VersionTest("select @@version");
-
     [TestMethod]
-    public void SelectVersion_MixedCase() => VersionTest("Select @@Version");
+    [DataRow("SELECT @@VERSION")]
+    [DataRow("select @@version")]
+    [DataRow("Select @@Version")]
+    public void SelectVersion(string commandText) => Assert.AreEqual("SQL Server Simulator", new Simulation().ExecuteScalar(commandText));
 
     [TestMethod]
-    public void SelectParameterValue()
+    [DataRow("select @p0", "p0", 5)]
+    [DataRow("select @p0", "@p0", 6)]
+    public void SelectParameterValue(string commandText, string name, object value)
     {
         var result = new Simulation()
             .CreateOpenConnection()
-            .CreateCommand("select @p0", ("@p0", 5))
+            .CreateCommand(commandText, (name, value))
             .ExecuteScalar();
 
-        Assert.AreEqual(5, result);
-    }
-
-    [TestMethod]
-    public void SelectParameterValueWithAtInName()
-    {
-        var result = new Simulation()
-            .CreateOpenConnection()
-            .CreateCommand("select @p0", ("@p0", 6))
-            .ExecuteScalar();
-
-        Assert.AreEqual(6, result);
+        Assert.AreEqual(value, result);
     }
 
     [TestMethod]
@@ -67,130 +52,58 @@ public void Select1Plus1()
     }
 
     [TestMethod]
-    public void SelectAliasedExpression()
-    {
-        using var reader = new Simulation().ExecuteReader("select 1 as c");
-
-        Assert.IsTrue(reader.Read());
-        Assert.AreEqual("c", reader.GetName(0));
-        Assert.AreEqual(1, reader.GetInt32(0));
-    }
-
-    [TestMethod]
-    public void SelectAliasedMathExpression()
+    [DataRow("select 1 as c", "c", 1)]
+    [DataRow("select 1 + 1 as c", "c", 2)]
+    public void Expression(string commandText, string name, object value)
     {
-        using var reader = new Simulation().ExecuteReader("select 1 + 1 as c");
+        using var reader = new Simulation().ExecuteReader(commandText);
 
         Assert.IsTrue(reader.Read());
-        Assert.AreEqual("c", reader.GetName(0));
-        Assert.AreEqual(2, reader.GetInt32(0));
+        Assert.AreEqual(name, reader.GetName(0));
+        Assert.AreEqual(value, reader[0]);
     }
 
     [TestMethod]
-    public void SelectExpressionFromSystemTable()
+    [DataRow("select 1 from systypes", 34, 1, 1)]
+    [DataRow("select 1 from systypes as s", 34, 1, 1)]
+    [DataRow("select name from systypes", 34, 34, "image")]
+    public void ExpressionFromTable(string commandText, int minimumRows, int uniqueRows, object value)
     {
-        using var reader = new Simulation().ExecuteReader("select 1 from systypes");
+        using var reader = new Simulation().ExecuteReader(commandText);
 
         var results = reader
             .EnumerateRecords()
-            .Take(34) // There might be more someday, but there won't be less.
-            .Select(reader => reader.GetInt32(0))
+            .Take(minimumRows) // There might be more someday, but there won't be less.
+            .Select(reader => reader[0])
             .ToArray();
 
-        Assert.HasCount(34, results);
-        Assert.HasCount(1, results.ToHashSet());
-        Assert.AreEqual(1, results[0]);
+        Assert.HasCount(minimumRows, results);
+        Assert.HasCount(uniqueRows, results.ToHashSet());
+        Assert.AreEqual(value, results[0]);
     }
 
     [TestMethod]
-    public void SelectExpressionFromAliasedSystemTable()
+    [DataRow("select name as c from systypes", 34, 34, "c", "image")]
+    [DataRow("select name as c from systypes as s", 34, 34, "c", "image")]
+    [DataRow("select systypes.name from systypes", 34, 34, "name", "image")]
+    [DataRow("select s.name from systypes as s", 34, 34, "name", "image")]
+    public void NamedExpressionFromTable(string commandText, int minimumRows, int uniqueRows, string name, object value)
     {
-        using var reader = new Simulation().ExecuteReader("select 1 from systypes as s");
+        using var reader = new Simulation().ExecuteReader(commandText);
 
         var results = reader
             .EnumerateRecords()
-            .Take(34) // There might be more someday, but there won't be less.
-            .Select(reader => reader.GetInt32(0))
+            .Take(minimumRows) // There might be more someday, but there won't be less.
+            .Select(reader =>
+            {
+                Assert.AreEqual(name, reader.GetName(0));
+                return reader[0];
+            })
             .ToArray();
 
-        Assert.HasCount(34, results);
-        Assert.HasCount(1, results.ToHashSet());
-        Assert.AreEqual(1, results[0]);
-    }
-
-    [TestMethod]
-    public void SelectColumnFromSystemTable()
-    {
-        using var reader = new Simulation().ExecuteReader("select name from systypes");
-
-        var results = reader
-            .EnumerateRecords()
-            .Take(34) // There might be more someday, but there won't be less.
-            .Select(reader => reader.GetString(0))
-            .ToHashSet();
-
-        Assert.HasCount(34, results);
-        Assert.Contains("int", results);
-    }
-
-    [TestMethod]
-    public void SelectAliasedColumnFromSystemTable()
-    {
-        using var reader = new Simulation().ExecuteReader("select name as c from systypes");
-
-        var results = reader
-            .EnumerateRecords()
-            .Take(34) // There might be more someday, but there won't be less.
-            .Select(reader => reader.GetName(0))
-            .ToHashSet();
-
-        Assert.HasCount(1, results);
-        Assert.Contains("c", results);
-    }
-
-    [TestMethod]
-    public void SelectAliasedColumnFromAliasedSystemTable()
-    {
-        using var reader = new Simulation().ExecuteReader("select name as c from systypes as s");
-
-        var results = reader
-            .EnumerateRecords()
-            .Take(34) // There might be more someday, but there won't be less.
-            .Select(reader => reader.GetName(0))
-            .ToHashSet();
-
-        Assert.HasCount(1, results);
-        Assert.Contains("c", results);
-    }
-
-    [TestMethod]
-    public void SelectMultiPartColumnFromSystemTable()
-    {
-        using var reader = new Simulation().ExecuteReader("select systypes.name from systypes");
-
-        var results = reader
-            .EnumerateRecords()
-            .Take(34) // There might be more someday, but there won't be less.
-            .Select(reader => reader.GetName(0))
-            .ToHashSet();
-
-        Assert.HasCount(1, results);
-        Assert.Contains("name", results);
-    }
-
-    [TestMethod]
-    public void SelectMultiPartColumnFromAliasedSystemTable()
-    {
-        using var reader = new Simulation().ExecuteReader("select s.name from systypes as s");
-
-        var results = reader
-            .EnumerateRecords()
-            .Take(34) // There might be more someday, but there won't be less.
-            .Select(reader => reader.GetName(0))
-            .ToHashSet();
-
-        Assert.HasCount(1, results);
-        Assert.Contains("name", results);
+        Assert.HasCount(minimumRows, results);
+        Assert.HasCount(uniqueRows, results.ToHashSet());
+        Assert.AreEqual(value, results[0]);
     }
 
     [TestMethod]