WaitForDelay timing assertions widen from 100/500ms to 2000ms: the original timings were unnecessarily aggressive and not reliable on slow/busy test runner systems.

Author: RyanLamansky

SqlServerSimulator.Tests/WaitForDelayTests.cs

@@ -56,8 +56,8 @@ public void Delay_50ms_ActuallySleeps()
         var elapsed = Stopwatch.GetElapsedTime(start);
         IsGreaterThanOrEqualTo(40, elapsed.TotalMilliseconds,
             $"Expected ≥40ms sleep, got {elapsed.TotalMilliseconds}ms");
-        IsLessThan(500, elapsed.TotalMilliseconds,
-            $"Expected <500ms sleep, got {elapsed.TotalMilliseconds}ms");
+        IsLessThan(2000, elapsed.TotalMilliseconds,
+            $"Expected well under a misparsed-magnitude sleep, got {elapsed.TotalMilliseconds}ms");
     }
 
     [TestMethod]
@@ -68,8 +68,8 @@ public void Delay_InUntakenIf_DoesNotSleep()
         var start = Stopwatch.GetTimestamp();
         _ = new Simulation().ExecuteNonQuery("if 1=0 waitfor delay '00:00:10'");
         var elapsed = Stopwatch.GetElapsedTime(start);
-        IsLessThan(100, elapsed.TotalMilliseconds,
-            $"Expected near-instant skip, got {elapsed.TotalMilliseconds}ms");
+        IsLessThan(2000, elapsed.TotalMilliseconds,
+            $"Expected skip well under the guarded 10s sleep, got {elapsed.TotalMilliseconds}ms");
     }
 
     [TestMethod]
@@ -78,8 +78,8 @@ public void Delay_AfterReturn_DoesNotSleep()
         var start = Stopwatch.GetTimestamp();
         _ = new Simulation().ExecuteNonQuery("return; waitfor delay '00:00:10'");
         var elapsed = Stopwatch.GetElapsedTime(start);
-        IsLessThan(100, elapsed.TotalMilliseconds,
-            $"Expected near-instant skip, got {elapsed.TotalMilliseconds}ms");
+        IsLessThan(2000, elapsed.TotalMilliseconds,
+            $"Expected skip well under the guarded 10s sleep, got {elapsed.TotalMilliseconds}ms");
     }
 
     [TestMethod]
@@ -94,8 +94,8 @@ public void Delay_AfterBreak_DoesNotSleep()
             end
             """);
         var elapsed = Stopwatch.GetElapsedTime(start);
-        IsLessThan(100, elapsed.TotalMilliseconds,
-            $"Expected near-instant skip, got {elapsed.TotalMilliseconds}ms");
+        IsLessThan(2000, elapsed.TotalMilliseconds,
+            $"Expected skip well under the guarded 10s sleep, got {elapsed.TotalMilliseconds}ms");
     }
 
     [TestMethod]
@@ -204,7 +204,7 @@ public void Delay_InWhile_RunsEachIteration()
             end
             """);
         var elapsed = Stopwatch.GetElapsedTime(start);
-        IsLessThan(500, elapsed.TotalMilliseconds,
+        IsLessThan(2000, elapsed.TotalMilliseconds,
             $"Expected fast loop, got {elapsed.TotalMilliseconds}ms");
     }
 }