fix: replace non-canonical (integer) cast deprecated in PHP 8.5#53
Open
wombatbuddy wants to merge 1 commit into
Open
fix: replace non-canonical (integer) cast deprecated in PHP 8.5#53wombatbuddy wants to merge 1 commit into
wombatbuddy wants to merge 1 commit into
Conversation
…twork.php and Range.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.5+ deprecates non-canonical type cast aliases
(integer),(boolean),(double)and(binary). Using these aliases produces a deprecation notice on PHP 8.5+ which will become a fatal error in a future PHP version.Steps to reproduce
Run tests on PHP 8.5:
vendor/bin/phpunit --display-deprecations
You will see:
Non-canonical cast (integer) is deprecated, use the (int) cast instead
Solution
Replace with canonical alias:
(integer) → (int)
References
Note on maintainability
Meanwhile, a compatible fork is available at: https://packagist.org/packages/wombatbuddy/iptools