refactor: replace CPUSample.getValue(1) with CPUSample.getTime()

Author: Lslightly

qlsrc/pprof_ext/cpuprofile.qll

@@ -35,9 +35,9 @@ class CPUProfile extends Profile {
      * Sum of all sample values at index 1 (total time in nanoseconds).
      */
     QlBuiltins::BigInt sampleTimeSum() {
-        result = sum(Sample sample
+        result = sum(CPUSample sample
             | super.getSample(_) = sample
-            | sample.getValue(1)
+            | sample.getTime()
         )
     }
 
@@ -46,10 +46,10 @@ class CPUProfile extends Profile {
      */
     bindingset[funcFullName]
     QlBuiltins::BigInt cumTimeOfFunc(string funcFullName) {
-        result = sum(Sample sample
+        result = sum(CPUSample sample
             | super.getSample(_) = sample and
             sample.containsFunc(funcFullName)
-            | sample.getValue(1) // time is at index 1
+            | sample.getTime()
         )
     }
 
@@ -60,11 +60,11 @@ class CPUProfile extends Profile {
      */
     bindingset[funcFullName]
     QlBuiltins::BigInt flatTimeOfFunc(string funcFullName) {
-        result = sum(Sample sample
+        result = sum(CPUSample sample
             | super.getSample(_) = sample and
             sample.containsFunc(funcFullName) and
             sample.getLocation(0).getLine(_).getFunction().getName() = funcFullName
-            | sample.getValue(1) // time is at index 1
+            | sample.getTime()
         )
     }
 
@@ -73,10 +73,10 @@ class CPUProfile extends Profile {
      */
     bindingset[funcFullName, lineNumber]
     QlBuiltins::BigInt cumTimeOfLine(string funcFullName, int lineNumber) {
-        result = sum(Sample sample
+        result = sum(CPUSample sample
             | super.getSample(_) = sample and
             sample.containsLine(funcFullName, lineNumber)
-            | sample.getValue(1) // time is at index 1
+            | sample.getTime()
         )
     }
 
@@ -95,11 +95,11 @@ class CPUProfile extends Profile {
      */
     bindingset[funcFullName, focusfuncFullName]
     QlBuiltins::BigInt cumTimeUnderFunc(string funcFullName, string focusfuncFullName) {
-        result = sum(Sample sample
+        result = sum(CPUSample sample
             | super.getSample(_) = sample and
             sample.containsFunc(funcFullName) and
             sample.containsFunc(focusfuncFullName)
-            | sample.getValue(1)
+            | sample.getTime()
         )
     }
 

qlsrc/pprof_ext/malloc_time.ql

@@ -32,7 +32,7 @@ string mallocgc() {
  *   - mallocgcin16:          mallocgc time within BenchmarkMalloc16 context (seconds)
  */
 from CPUProfile profile
-select (sum(QlBuiltins::BigInt time, Sample sample | time = sample.getValue(1) and containsMallocgc(sample) | time)/1000000.toBigInt()).toInt() as mallocgc_time_ms, 
+select (sum(QlBuiltins::BigInt time, CPUSample sample | time = sample.getTime() and containsMallocgc(sample) | time)/1000000.toBigInt()).toInt() as mallocgc_time_ms, 
     profile.funcPercent(mallocgc(), 2) as mallocgc_percent,
     timeInUnit(profile.cumTimeOfFunc(mallocgc()), "s", 2) as cumTime,
     timeInUnit(profile.flatTimeOfFunc(mallocgc()), "s", 2) as flatTime,