fix online list request#204
Merged
Merged
Conversation
IgorKhomenko
approved these changes
Mar 27, 2026
IgorKhomenko
reviewed
May 5, 2026
| export const watchdogPingSocket = async (logger, sessionService, onWsCloseCb, onTcpCloseCb) => { | ||
| const users = Object.keys(sessionService.activeSessions.DEVICES) | ||
|
|
||
| logger.debug("[run] %s", users.length) |
Contributor
There was a problem hiding this comment.
logger.debug("[watchdogPingSocket][run] %s", users.length)
IgorKhomenko
reviewed
May 5, 2026
| connection.socket?.send(pingPackage) | ||
| } | ||
| } catch (error) { | ||
| logger.error(error, "[error socket send] %s", userId) |
Contributor
There was a problem hiding this comment.
logger.error(error, "[watchdogPingSocket][error socket send] %s", userId)
IgorKhomenko
reviewed
May 5, 2026
| if (isTCP) { | ||
| await onTcpCloseCb(connection?.socket) | ||
| .then(() => logger.debug("[close tcp done] %s", userId)) | ||
| .catch(error => logger.error(error, "[close tcp error]")) |
Contributor
There was a problem hiding this comment.
.catch(error => logger.error(error, "[watchdogPingSocket][close tcp error]"))
IgorKhomenko
reviewed
May 5, 2026
| } else { | ||
| await onWsCloseCb(connection?.socket, 10) | ||
| .then(() => logger.debug("[close ws done] %s", userId)) | ||
| .catch(error => logger.error(error, "[close ws error]")) |
Contributor
There was a problem hiding this comment.
.catch(error => logger.error(error, "[watchdogPingSocket][close ws error]"))
IgorKhomenko
approved these changes
May 5, 2026
banshiAnton
added a commit
that referenced
this pull request
May 12, 2026
* fix online list request (#204) * fix online list request * add basic cmd ws test commands * update check cmd connections * add close * add socketCloseWatchdog * add remove session * on close logs debug * add repl service * update docker-file * add ping socket * update package * fix tcp send failed * update watchdogPingSocket * add logs * update addUserDeviceConnection * update submodule * changelog: v0.36.2
banshiAnton
added a commit
that referenced
this pull request
Jul 7, 2026
* fix online list request (#204) * fix online list request * add basic cmd ws test commands * update check cmd connections * add close * add socketCloseWatchdog * add remove session * on close logs debug * add repl service * update docker-file * add ping socket * update package * fix tcp send failed * update watchdogPingSocket * add logs * update addUserDeviceConnection * update submodule * changelog: v0.36.2 * Imp node clustering (#205) * update logs * sync activity cluster * update activity service * imp base clean node data * it can send offline status for died node users * refactoring * fix spec * update config * refactor PacketManager * it can clear destoyed node cache data * update clean node conditions * add reconnecting * add Node Clustering readme * it can close ws with code * reconnecty only ifWas opened * fix typo * start testing * add activty listening * update same-node / cross-node specs * add fixtures * update specs * it can connect with token * test reconnecting * update specs * update specs: add dummy data * update spec titles * update install docker * add hostname to stats * update cors header * add logs * add log * add logs * close cluster socket on delete * fix config * remove session with old node endpoint * add client cluster test * update testing clients cluster * add check last activity * add repl services * fix typo in env * fix env val * update * add netcat install to dockerfile * update addUserDeviceConnection * add keep alive * fix typo * update submodule * use res instead of res.fakeWsSessionKey * watchdogPingSocket ignore HTTP_DEVICE_ID * update * try fix listUserDevice * try fix listUserDevice * update listUserDevice * add to session service filterActualDevices * update addUserDeviceConnection and storeUserNodeData * update package * add logs * add log * it can block create_user/auth if account was blocked * update env * update @sama-communications/sdk * update requestTrackId in error response * add cluster env CLUSTER_ADVERTISE_IP * update workflows * add workflow_dispatch * update workflows tests * update env docker * formating * update submodule * update submodule to main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.