Revert "Add protected getter for settings to ease extension"

This reverts commit 91fb559.

Author: mauromol

core/src/main/java/com/onelogin/saml2/authn/AuthnRequest.java

@@ -288,13 +288,4 @@ public String getId()
 	public Calendar getIssueInstant() {
 		return issueInstant == null? null: (Calendar) issueInstant.clone();
 	}
-
-	/**
-	 * Returns the SAML settings specified at construction time.
-	 * 
-	 * @return the SAML settings
-	 */
-	protected Saml2Settings getSettings() {
-		return settings;
-	}
 }

core/src/main/java/com/onelogin/saml2/authn/SamlResponse.java

@@ -41,13 +41,13 @@
  */
 public class SamlResponse {
 	/**
-       * Private property to construct a logger for this class.
-       */
+     * Private property to construct a logger for this class.
+     */
 	private static final Logger LOGGER = LoggerFactory.getLogger(SamlResponse.class);
 
 	/**
-       * Settings data.
-       */
+     * Settings data.
+     */
 	private final Saml2Settings settings;
 
 	/**
@@ -1322,13 +1322,4 @@ public Calendar getResponseIssueInstant() throws ValidationError {
 		}
 		return result;
 	}
-
-	/**
-	 * Returns the SAML settings specified at construction time.
-	 * 
-	 * @return the SAML settings
-	 */
-	protected Saml2Settings getSettings() {
-		return settings;
-	}
 }

core/src/main/java/com/onelogin/saml2/logout/LogoutRequest.java

@@ -829,13 +829,4 @@ public String getId()
 	public Calendar getIssueInstant() {
 		return issueInstant == null? null: (Calendar) issueInstant.clone();
 	}
-	
-	/**
-	 * Returns the SAML settings specified at construction time.
-	 * 
-	 * @return the SAML settings
-	 */
-	protected Saml2Settings getSettings() {
-		return settings;
-	}
 }

core/src/main/java/com/onelogin/saml2/logout/LogoutResponse.java

@@ -534,13 +534,4 @@ public Calendar getIssueInstant() throws ValidationError {
 		} else
 			return issueInstant == null? null: (Calendar) issueInstant.clone();
 	}
-
-	/**
-	 * Returns the SAML settings specified at construction time.
-	 * 
-	 * @return the SAML settings
-	 */
-	protected Saml2Settings getSettings() {
-		return settings;
-	}
 }

core/src/main/java/com/onelogin/saml2/settings/Metadata.java

@@ -62,11 +62,6 @@ public class Metadata {
 	 */
 	private final Integer cacheDuration;
 
-	/**
-       * Settings data.
-       */
-	private final Saml2Settings settings;
-
 	/**
 	 * Constructs the Metadata object.
 	 *
@@ -77,7 +72,6 @@ public class Metadata {
 	 * @throws CertificateEncodingException
 	 */
 	public Metadata(Saml2Settings settings, Calendar validUntilTime, Integer cacheDuration, AttributeConsumingService attributeConsumingService) throws CertificateEncodingException {
-		this.settings = settings;
 		this.validUntilTime = validUntilTime;
 		this.attributeConsumingService = attributeConsumingService;
 		this.cacheDuration = cacheDuration;
@@ -108,7 +102,7 @@ public Metadata(Saml2Settings settings, Calendar validUntilTime, Integer cacheDu
 	 * @throws CertificateEncodingException
 	 */
 	public Metadata(Saml2Settings settings) throws CertificateEncodingException {
-		this.settings = settings;
+
 		this.validUntilTime = Calendar.getInstance();
 		this.validUntilTime.add(Calendar.DAY_OF_YEAR, N_DAYS_VALID_UNTIL);
 
@@ -413,13 +407,4 @@ public static String signMetadata(String metadata, PrivateKey key, X509Certifica
 		LOGGER.debug("Signed metadata --> " + signedMetadata);
 		return signedMetadata;
 	}
-	
-	/**
-	 * Returns the SAML settings specified at construction time.
-	 * 
-	 * @return the SAML settings
-	 */
-	protected Saml2Settings getSettings() {
-		return settings;
-	}
 }