Skip to content

Commit b192e2a

Browse files
committed
Add OneLogin_Saml2_Authn_Request._generate_request_id() override point
Refs #208 (comment)
1 parent 589425d commit b192e2a

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/onelogin/saml2/authn_request.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ def __init__(self, settings, force_authn=False, is_passive=False, set_nameid_pol
4747
idp_data = self.__settings.get_idp_data()
4848
security = self.__settings.get_security_data()
4949

50-
uid = OneLogin_Saml2_Utils.generate_unique_id()
51-
self.__id = uid
50+
self.__id = self._generate_request_id()
5251
issue_instant = OneLogin_Saml2_Utils.parse_time_to_SAML(OneLogin_Saml2_Utils.now())
5352

5453
destination = idp_data['singleSignOnService']['url']
@@ -113,7 +112,7 @@ def __init__(self, settings, force_authn=False, is_passive=False, set_nameid_pol
113112

114113
request = OneLogin_Saml2_Templates.AUTHN_REQUEST % \
115114
{
116-
'id': uid,
115+
'id': self.__id,
117116
'provider_name': provider_name_str,
118117
'force_authn_str': force_authn_str,
119118
'is_passive_str': is_passive_str,
@@ -129,6 +128,14 @@ def __init__(self, settings, force_authn=False, is_passive=False, set_nameid_pol
129128

130129
self.__authn_request = request
131130

131+
def _generate_request_id(self):
132+
"""
133+
Generate an unique request ID.
134+
135+
You can override this in a subclass.
136+
"""
137+
return OneLogin_Saml2_Utils.generate_unique_id()
138+
132139
def get_request(self, deflate=True):
133140
"""
134141
Returns unsigned AuthnRequest.

0 commit comments

Comments
 (0)