Skip to content

Commit 32b1fe6

Browse files
authored
Merge pull request #788 from fkmy/fix-readme
Fix typos and errors in README
2 parents 7e5b3d3 + 8bf4eb0 commit 32b1fe6

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Using `Gemfile`
8686
gem 'ruby-saml', '~> 1.18.0'
8787

8888
# or track master for bleeding-edge
89-
gem 'ruby-saml', :github => 'saml-toolkit/ruby-saml'
89+
gem 'ruby-saml', :github => 'saml-toolkits/ruby-saml'
9090
```
9191

9292
Using RubyGems
@@ -123,7 +123,7 @@ Using RubyGems
123123

124124
```sh
125125
gem install nokogiri --version '~> 1.5.10'
126-
````
126+
```
127127

128128
### Configuring Logging
129129

@@ -444,7 +444,7 @@ xml = response.body
444444
errors = []
445445
doc = XMLSecurity::SignedDocument.new(xml, errors)
446446
cert_str = "<include_cert_here>"
447-
cert = OneLogin::RubySaml::Utils.format_cert("cert_str")
447+
cert = OneLogin::RubySaml::Utils.format_cert(cert_str)
448448
metadata_sign_cert = OpenSSL::X509::Certificate.new(cert)
449449
valid = doc.validate_document_with_cert(metadata_sign_cert, true)
450450
if valid
@@ -752,7 +752,7 @@ settings.sp_cert_multi = {
752752
}
753753
```
754754

755-
Certificate rotation is acheived by inserting new certificates at the bottom of each list,
755+
Certificate rotation is achieved by inserting new certificates at the bottom of each list,
756756
and then removing the old certificates from the top of the list once your IdPs have migrated.
757757
A common practice is for apps to publish the current SP metadata at a URL endpoint and have
758758
the IdP regularly poll for updates.
@@ -803,7 +803,7 @@ Here is an example that we could add to our previous controller to generate and
803803
```ruby
804804
# Create a SP initiated SLO
805805
def sp_logout_request
806-
# LogoutRequest accepts plain browser requests w/o paramters
806+
# LogoutRequest accepts plain browser requests w/o parameters
807807
settings = saml_settings
808808

809809
if settings.idp_slo_service_url.nil?
@@ -1010,7 +1010,7 @@ You must store this ID in a persistent cache (like Redis or Memcached) that is s
10101010

10111011
The ID should be stored until the assertion's validity window has passed. You will need to check how long the trusted IdPs consider the assertion valid and then add the allowed_clock_drift.
10121012

1013-
You can define a global value, or set this value dinamically based on the `not_on_or_after` value of the re + `allowed_clock_drift`.
1013+
You can define a global value, or set this value dynamically based on the `not_on_or_after` value of the re + `allowed_clock_drift`.
10141014

10151015
```ruby
10161016
# In your `consume` action, after a successful validation:

0 commit comments

Comments
 (0)