Value Help for Nodejs bookshop sample#19
Merged
Merged
Conversation
|
|
finkmanAtSap
requested changes
Jul 14, 2025
finkmanAtSap
left a comment
finkmanAtSap
left a comment
Contributor
There was a problem hiding this comment.
Looks really good 😊 I just have some minor suggestions.
Co-authored-by: Manuel Fink <123368068+finkmanAtSap@users.noreply.github.com>
finkmanAtSap
requested changes
Jul 14, 2025
finkmanAtSap
left a comment
finkmanAtSap
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Looks good. I'm just a bit worried if the db.sqlite file is really in the required shape.
Perhaps you could verify this with a simple unit test for the value help service similar to cat-serivce.test.js
You should be able to authenticate as the mock user with name principal-propagation for this test like so.
As a second test, you could verify that alice has no access because she is lacking the Reader role afaik.
…lp; update .cdsrc.json and .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added value help for the genre attribute in the cap bookshop sample. Therefore I added the vh-service.cds and the added the value help annotation in the schema.dcl. Changes that need to be done in the mta.yaml file are described in the README.md file.