chore(deps): patch ws and form-data advisories in approuter#41
Merged
Conversation
Resolves two open Dependabot alerts: - #193 form-data <4.0.6 CRLF injection (high) -> form-data 4.0.6 - #194 ws <7.5.11 memory-exhaustion DoS (high) -> ws 7.5.11 How: - Lockfile in app/router/ was stale at @sap/approuter 21.5.0 even though PR #37 had already bumped the manifest to ^22.0.1. Regenerated it; npm resolves to @sap/approuter 22.0.3 (latest), which pulls axios 1.16.1 -> form-data 4.0.6. Closes #193. - @sap/approuter 22.0.3 still pins ws: '7.5.10' exactly, so a lockfile-only fix can't reach 7.5.11. Added an npm 'overrides' entry to force ws ^7.5.11. Closes #194. The override is a workaround until SAP bumps the ws pin in a future @sap/approuter release. ws 7.5.11 is a patch over 7.5.10 (same minor line), so the risk of regression is low; the approuter module still loads cleanly with the override applied. Verified: npm audit in app/router/ reports 0 vulnerabilities; node -e "require('@sap/approuter')" loads without errors.
rich-heilman
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes two open Dependabot alerts in solution/MyHANAApp/app/router/ — follow-up to #40.
form-datawsoverridesWhy two different fixes
form-data — lockfile was stale
The manifest already said
@sap/approuter: ^22.0.1(bumped by #37) but the lockfile was still pinning21.5.0— the bump never got reinstalled. Regeneratingpackage-lock.jsonresolves@sap/approuterto 22.0.3 (latest, 8 days old), which transitively pullsaxios 1.16.1→form-data 4.0.6. No manifest change needed for this one.ws — needs an explicit override
@sap/approuter@22.0.3declares an exact pin"ws": "7.5.10"(not a caret range). The advisory's fixed version is 7.5.11. Even the latest SAP release hasn't bumped the pin, so npm cannot bring in 7.5.11 transparently. Solution: an npmoverridesentry that forcesws@^7.5.11for this lockfile.7.5.11 is a patch on the same minor line as the pinned 7.5.10 (one commit in the upstream changelog, the GHSA-96hv-2xvq-fx4p mitigation), so the regression risk is very small. This is a temporary workaround until SAP bumps the pin in a future
@sap/approuterrelease — worth filing an issue with SAP to nudge that along.Verification
cd solution/MyHANAApp/app/router && npm install→found 0 vulnerabilitiesnode -e "require('@sap/approuter')"loads cleanly (no module-resolution errors with the override applied)