Update from zero to cap on kyma#555
Merged
Merged
Conversation
- Use approuter for a simple secure access - have 2 versions simple path and a detailed path
abbi-gaurav
requested review from
IwonaLanger,
NHingerl,
grego952,
mmitoraj and
nataliasitko
as code owners
mmitoraj
reviewed
Jun 11, 2025
Contributor
mmitoraj
left a comment
mmitoraj
left a comment
There was a problem hiding this comment.
- PTAL at the suggestion from the local file with the README I sent to you on Slack.
- The diagram does not use all the BTP Diagram Guidelines, but maybe I can fix that later, once the PR is merged. In the
.mdfile, I would use the.drawio.svgformat instead of.png. Please also add a white background so that the diagram is well displayed in the dark mode as well ( I can also fix it later). - Shouldn't the detailed path just show the more detailed actions, or do you prefer to repeat all the steps? Maybe we could mark these parts that are additional?
Member
Author
lets keep it separate, as steps are a bit different and it would be easier to follow |
mmitoraj
reviewed
Jun 13, 2025
- Update as per feedback
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
mmitoraj
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)