Provide a CAP bookstore sample#575
Closed
grego952 wants to merge 14 commits into
Closed
Conversation
grego952
requested review from
IwonaLanger,
NHingerl and
nataliasitko
as code owners
dbadura
approved these changes
Nov 21, 2025
kwiatekus
reviewed
Dec 1, 2025
| configMapKeyRef: | ||
| name: bookstore-postgres-config | ||
| key: CDS_REQUIRES_KIND | ||
| - name: POSTGRES_HOST |
Contributor
There was a problem hiding this comment.
I would expect the credentails should be mounted as a secret and consumable using @sap/xsenv cloud cdk, i.e
services = xsenv.getServices({
posgresql: { label: 'db' },
});
IwonaLanger
approved these changes
Jan 13, 2026
Contributor
Author
|
No longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)