TSD Support#7
Closed
PetyaMarkovaBogdanova wants to merge 10 commits intoenable-tsdfrom
Closed
Conversation
fix(uxc-integration): Enabled .d.ts generation for seamless wrappers
chore: Revert dependency
Revert "fix(uxc-integration): Enabled .d.ts generation for seamless wrappers"
fixed dependencies versions
- Switch from `npm install --package-lock=false` to `npm ci` for reproducible builds that respect package-lock.json - Bump actions/checkout v4 → v6 - Bump actions/setup-node v4 → v6 - Bump actions/configure-pages v5 → v6 - Bump actions/upload-pages-artifact v3 → v5 - Bump actions/deploy-pages v4 → v5
…onent.ts Both @ui5/webcomponents/dist/Assets and @ui5/webcomponents-fiori/dist/Assets were imported explicitly. Having both as separate rollup entry points caused ui5-tooling-modules to emit a deduplicated chunk named Assets2.js that was never written to disk, breaking the production build with a script load error. @ui5/webcomponents-fiori/dist/Assets already transitively imports @ui5/webcomponents/dist/Assets, so both manual imports are redundant.
…earch gen/ wrapping @ui5/webcomponents-fiori@2.21.x exports a DIFFERENT internal class named ShellBarSearch from dist/shellbar/ShellBarSearch.js (a search controller). WebComponentRegistry processes this export AFTER the public dist/ShellBarSearch.js export, overwriting the class's module path from "dist/ShellBarSearch.js" to "dist/shellbar/ShellBarSearch.js". This makes the registry lookup fail in lookupWebComponentsClass, so ShellBarSearch never receives a gen/ UI5 wrapper. Fix: change = to ??= in WebComponentRegistry.js#parseExports so the module path is only set on the first export (the correct public one), not overwritten. Also adds patch-package and postinstall hook to apply the fix persistently.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.