fix(uxc-integration): Enabled .d.ts generation for seamless wrappers#9
Open
PetyaMarkovaBogdanova wants to merge 1 commit intomainfrom
Open
fix(uxc-integration): Enabled .d.ts generation for seamless wrappers#9PetyaMarkovaBogdanova wants to merge 1 commit intomainfrom
PetyaMarkovaBogdanova wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving type safety and code clarity in the TypeScript controllers, as well as updating tooling and configuration for better development experience. The main changes include removing unnecessary type assertions and error suppressions, refactoring event handling to use UI5's APIs, and updating dependencies and middleware configuration.
TypeScript and Controller Improvements:
Removed unnecessary type assertions (as unknown as ...) and @ts-expect-error comments in App.controller.ts and Notifications.controller.ts, replacing them with direct and type-safe usage of UI5 Web Components and their APIs. [1] [2] [3] [4] [5] [6]
Refactored event handling for user menu and notifications in App.controller.ts to use UI5's attachItemClick and setter methods (setOpener, setOpen) instead of directly manipulating properties, increasing code robustness and future compatibility.
Tooling and Configuration Updates:
Upgraded ui5-tooling-modules dependency from 3.30.2 to 3.35.0 in package.json for improved module support and bug fixes.
Enhanced ui5.yaml server middleware configuration: disabled persistent cache for development and enabled DTS file generation for web components, improving developer workflow and TypeScript integration.
Internal Reference: BGSOFUIPIRIN-6943