Skip to content

Commit 09f5822

Browse files
committed
Fix Checkstyle
1 parent 5c126f1 commit 09f5822

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

cloudplatform/connectivity-apache-httpclient5/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultApacheHttpClient5Factory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ public HttpClient createHttpClient( @Nullable final HttpDestinationProperties de
5555
}
5656

5757
@Nonnull
58+
@SuppressWarnings( "PMD.CloseResource" ) // The HttpClient instance and the connection manager instance are not being closed here.
5859
private CloseableHttpClient buildHttpClient(
5960
@Nullable final HttpDestinationProperties destination,
6061
@Nonnull final RequestConfig requestConfig )

cloudplatform/connectivity-apache-httpclient5/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultConnectionPoolSettings.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,33 +52,33 @@ public class DefaultConnectionPoolSettings implements ConnectionPoolSettings
5252
*/
5353
@Nonnull
5454
@Builder.Default
55-
Duration connectTimeout = ConnectionPoolSettings.DEFAULT_TIMEOUT;
55+
Duration connectTimeout = DEFAULT_TIMEOUT;
5656

5757
/**
5858
* The default socket timeout value for I/O operations on connections.
5959
*/
6060
@Nonnull
6161
@Builder.Default
62-
Duration socketTimeout = ConnectionPoolSettings.DEFAULT_TIMEOUT;
62+
Duration socketTimeout = DEFAULT_TIMEOUT;
6363

6464
/**
6565
* The timeout when requesting a connection lease from the connection pool.
6666
*/
6767
@Nonnull
6868
@Builder.Default
69-
Duration connectionRequestTimeout = ConnectionPoolSettings.DEFAULT_TIMEOUT;
69+
Duration connectionRequestTimeout = DEFAULT_TIMEOUT;
7070

7171
/**
7272
* The maximum number of total connections in the pool.
7373
*/
7474
@Builder.Default
75-
int maxConnectionsTotal = ConnectionPoolSettings.DEFAULT_MAX_CONNECTIONS_TOTAL;
75+
int maxConnectionsTotal = DEFAULT_MAX_CONNECTIONS_TOTAL;
7676

7777
/**
7878
* The maximum number of connections per route (e.g., per remote host).
7979
*/
8080
@Builder.Default
81-
int maxConnectionsPerRoute = ConnectionPoolSettings.DEFAULT_MAX_CONNECTIONS_PER_ROUTE;
81+
int maxConnectionsPerRoute = DEFAULT_MAX_CONNECTIONS_PER_ROUTE;
8282

8383
/**
8484
* Creates a new {@link DefaultConnectionPoolSettings} with default values.

0 commit comments

Comments
 (0)